-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: plugins can now be spawned as Workers #42
feat: plugins can now be spawned as Workers #42
Conversation
Tests seem to be failing due to empty environment variables during the tests |
@rndquu youre admin please facilitate |
Check this workflow How it works right now:
If here we change the code to checkout the PR branch using So right now this workflow is literally 1 line away from leaking secrets. There are viable 2 options: |
@rndquu will be mocking as we cannot have dummy values since it tries to reach a real endpoint. |
Changes in this PR
Test still expected to fail for |
we can merge this, right? |
@whilefoo was waiting for second validation but if you're good with it for sure |
f46b3f2
into
ubiquity-os:development
Resolves #39