Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render ENS Name Fix #52

Closed
0x4007 opened this issue Apr 26, 2023 · 15 comments · Fixed by #54
Closed

Render ENS Name Fix #52

0x4007 opened this issue Apr 26, 2023 · 15 comments · Fixed by #54

Comments

@0x4007
Copy link
Member

0x4007 commented Apr 26, 2023

renderEnsName relies on some random person's Cloudflare function which appears to be down. We should make our own solution. I hope that we can handle this entirely from the front-end?

We should also make all of our requests non blocking in case they fail!

image

Originally posted by @pavlovcik in #42 (comment)

@Steveantor
Copy link
Contributor

image
we shouldn't hide the permit details for the claimed ones

@0x4007
Copy link
Member Author

0x4007 commented Apr 26, 2023

image

we shouldn't hide the permit details for the claimed ones

What's the business case for needing to see permit details? If it's for developer debugging they should look on the command line or something.

@seprintour
Copy link
Contributor

What needs to be done here?

@seprintour
Copy link
Contributor

What's the business case for needing to see permit details? If it's for developer debugging they should look on the command line or something.

Yea, just saw the txData is stored on the browser window

@0x4007
Copy link
Member Author

0x4007 commented Apr 26, 2023

What needs to be done here?

The issue needs to be diagnosed and resolved. I'll eventually attempt to diagnose but its not a top priority for me personally at the moment.

@seprintour
Copy link
Contributor

seprintour commented Apr 26, 2023

What needs to be done here?

The issue needs to be diagnosed and resolved. I'll eventually attempt to diagnose but its not a top priority for me personally at the moment.

Error: missing revert data in call exception; Transaction reverted without a reason string [ See: https://links.ethers.org/v5-errors-CALL_EXCEPTION ] error={"reason":"processing response error","code":"SERVER_ERROR","body":"{\"jsonrpc\":\"2.0\",\"id\":44,\"error\":{\"code\":-32001,\"message\":\"Resource not found.\"}}","error":{"code":-32001}

Could it be this?, Looks like an RPC error

@0x4007
Copy link
Member Author

0x4007 commented Apr 26, 2023

Found it. renderEnsName/ensResolve relies on some random person's Cloudflare function which appears to be down. We should make our own solution. We should also make all of our requests non blocking in case they fail!

@0x4007 0x4007 changed the title Inconsistent Crash Render ENS Name Fix Apr 26, 2023
@0x4007
Copy link
Member Author

0x4007 commented Apr 26, 2023

/assign

@ubiquibot
Copy link

ubiquibot bot commented Apr 26, 2023

@pavlovcik The time limit for this bounty is on Wed, 26 Apr 2023 12:03:43 GMT

It looks like you haven't set your wallet address,
please use /wallet 0x4FDE...BA18 to do so.
(It's required to be paid for the bounty)

@0x4007
Copy link
Member Author

0x4007 commented Apr 26, 2023

/wallet ubq.eth

@ubiquibot
Copy link

ubiquibot bot commented Apr 26, 2023

Updated the wallet address for @pavlovcik successfully! Your new address: 0xefC0e701A824943b469a694aC564Aa1efF7Ab7dd

@0x4007
Copy link
Member Author

0x4007 commented Apr 26, 2023

I just realized that we should create endpoint(s) that can substitute as a provider in case there is no injected provider. Right now I can't render ENS without a web3 enabled browser! 😔

I guess we should make a new repository to host serverlessly?

@seprintour
Copy link
Contributor

I just realized that we should create endpoint(s) that can substitute as a provider in case there is no injected provider. Right now I can't render ENS without a web3 enabled browser! 😔

I guess we should make a new repository to host serverlessly?

I think we can just use another reliable ens api

@0x4007
Copy link
Member Author

0x4007 commented Apr 26, 2023

I think we can just use another reliable ens api

My pull request is already finished lol I just forked their API.

@ubiquibot
Copy link

ubiquibot bot commented Apr 27, 2023

[ CLAIM 37.5 DAI ]

0xefC0e701...fF7Ab7dd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants