Better Audit UI #109
Better Audit UI #109
Conversation
|
Oops, Github disabled my PAT because its on this PR.. so which means we might have to find a way to hardcode the PAT |
|
@rndquu ready for review |
Thank you, I'll check it today |
|
From the original issue: So, is github PAT necessary for calling github APIs? Did you try calling github APIs with an empty PAT? |
Yea, it works but gets crazy late limited without the PAT. It would be a problem to fetch comments because of the constant ban on IP, so we def need it |
There was a problem hiding this comment.
- Github automatically invalidates all PATs this it finds in repositories. Pls bring back the "Github PAT" text field and read PAT from that field. No need to hardcode it. Besides calling the audit script with the single hardcoded PAT increases chances of hitting rate limits.
3. If you run the audit script and wait for it to finish, and then click the "Get report" button again then issues appear with empty tx URLs
|
@rndquu Fixed these, try to test again |
|
Why the following issues are missing in the audit table when running for the https://github.com/ubiquity/pay.ubq.fi repo?
|
There was a problem hiding this comment.
Loader icon is missing
How to reproduce:
- Disable cache
- Run the script and wait for it to finish
- Click the "Get report" button
On step 3 the loader icon in the "Get report" button is going to be missed although the audit script will be running (if you check the console)
I just checked, the permits were never used so no I can also confirm I've not withdrawn this #86 |
Traced the problem and fixed |
@pavlovcik Do we need to display closed issues with unclaimed permits in the audit result table? Right now only issues with claimed permits are shown |
|
I think this would be fixed better by the time we implement claim all (making it easier to claim permits) It also depends on the purpose of the audit page, is it to show issues solved/progress or to display issues solved and money spent. Personally, I think if a permit isn't claimed then there's no need for an audit, it'd just be the same as going through github to view the closed issues if a tx hash isn't attached on the audit |
That's a good question I'm not sure off hand. I'll know much better after using it. However if there is a way to pull in all the claims information (claimed and unclaimed) to the audit page, and then later add filters to display the useful information to the auditor, that approach seems to make the most sense to me. |
That'd be hundreds of issues and It'd take a lot of time at the current functionality to get everything and then filter out the claimed.. The reason it takes a shorter time now is it prioritises the txHash and does its search from there. Maybe by the time we move over to fetching from DB and its a lot more memory intensive.. it'd be okay to mix issues without a txHash and then add a checkbox to hide/show besides making it show unclaimed right now, is changing most of the underlying code and rewriting the queue functionality (not in scope for this issue) |
Created a separate issue for displaying issues with unclaimed permits ubiquity/audit.ubq.fi#5 This PR looks good, pls review |
resolves #100
Remove the "Etherscan API Key" text input. ✅
Remove the "RPC URL" text input. ✅
Remove the "Owner name" field. ✅
Refactor the "Repository name" field to "Project URLs ✅
Modify the analytics table to contain the following columns:
Add a search text field above all of the table columns for filtering results ✅
I also added a sort for the
Amount