Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audit dApp: Show issues with unclaimed permits #5

Closed
rndquu opened this issue Jul 26, 2023 · 35 comments · Fixed by #2
Closed

audit dApp: Show issues with unclaimed permits #5

rndquu opened this issue Jul 26, 2023 · 35 comments · Fixed by #2

Comments

@rndquu
Copy link
Member

rndquu commented Jul 26, 2023

Depends on ubiquity/pay.ubq.fi#100, ubiquity/pay.ubq.fi#110

Right now the audit page only displays issues with claimed permits.

We should also show issues with unclaimed permits.

@PhantomCracker
Copy link

Can we set the price so we can assign this?
Also, @rndquu we should show all the issues that are closed, right?

@ubiquibot
Copy link

ubiquibot bot commented Jul 27, 2023

Available commands

- /assign: Assign the origin sender to the issue automatically.
- /unassign: Unassign the origin sender from the issue automatically.
- /help: List all available commands.
- /multiplier: Set the bounty payout multiplier for a specific contributor, and provide the reason for why. 
  example usage: "/wallet @user 0.5 'Multiplier reason'"
- /allow: Set access control. (Admin Only)
- /wallet: <WALLET_ADDRESS | ENS_NAME>: Register the hunter's wallet address. 
  ex1: /wallet 0xf39fd6e51aad88f6f4ce6ab8827279cfffb92266 
  ex2: /wallet vitalik.eth

@PhantomCracker

@PhantomCracker
Copy link

/assign

@ubiquibot
Copy link

ubiquibot bot commented Jul 27, 2023

Deadline Thu, 27 Jul 2023 09:38:03 GMT
Registered Wallet 0xCAC0A8cF4cc7073b040c7fe6328Da7f229AF40A6
Payment Multiplier 1.00
Multiplier Reason
Total Bounty Permit generation skipped since price label is not set
Tips:
  • Use /wallet 0x4FDE...BA18 if you want to update your registered payment wallet address @user.
  • Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
  • Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the bounty.

    @rndquu
    Copy link
    Member Author

    rndquu commented Jul 27, 2023

    Also, @rndquu we should show all the issues that are closed, right?

    Yes

    @ubiquibot
    Copy link

    ubiquibot bot commented Jul 31, 2023

    Do you have any updates @PhantomCracker? If you would like to release the bounty back to the DevPool, please comment /unassign
    Last activity time: Thu Jul 27 2023 08:38:01 GMT+0000 (Coordinated Universal Time)

    @PhantomCracker
    Copy link

    Work in progress here, I think today I will finish it

    @PhantomCracker
    Copy link

    @rndquu can I have the etherscan API and RPC url?

    @rndquu
    Copy link
    Member Author

    rndquu commented Aug 1, 2023

    @rndquu can I have the etherscan API and RPC url?

    Check the code

    @PhantomCracker
    Copy link

    PhantomCracker commented Aug 3, 2023

    @rndquu I am not sure what I do wrong here...
    Screenshot 2023-08-03 at 18 52 47

    @devpanther
    Copy link

    devpanther commented Aug 3, 2023

    @rndquu I am not sure what I do wrong here...

    You are supposed to be on the /audit path

    @PhantomCracker
    Copy link

    PhantomCracker commented Aug 4, 2023

    You are supposed to be on the /audit path

    Can you be more specific please? Maybe you can provide an example of URL?... I just don't get it where this audit page is 😢
    Screenshot 2023-08-04 at 10 14 13

    @devpanther
    Copy link

    You are supposed to be on the /audit path

    Can you be more specific please? Maybe you can provide an example of URL?... I just don't get it where this audit page is 😢
    Screenshot 2023-08-04 at 10 14 13

    Make it http://localhost:8080/audit.html

    @ubiquibot
    Copy link

    ubiquibot bot commented Aug 8, 2023

    Do you have any updates @PhantomCracker? If you would like to release the bounty back to the DevPool, please comment /unassign
    Last activity time: Fri Aug 04 2023 07:13:42 GMT+0000 (Coordinated Universal Time)

    @PhantomCracker
    Copy link

    I guess that today I will release the PR :) I really hope so

    @0x4007
    Copy link
    Member

    0x4007 commented Aug 8, 2023

    You should be working on a draft pull request.

    @PhantomCracker
    Copy link

    Ok, I will open it now.

    @ubiquibot
    Copy link

    ubiquibot bot commented Aug 16, 2023

    Do you have any updates @PhantomCracker? If you would like to release the bounty back to the DevPool, please comment /stop
    Last activity time: Thu Aug 10 2023 14:18:03 GMT+0000 (Coordinated Universal Time)

    @ubiquibot
    Copy link

    ubiquibot bot commented Aug 17, 2023

    @PhantomCracker - Releasing the bounty back to dev pool because the allocated duration already ended!
    Last activity time: Thu Aug 10 2023 14:18:03 GMT+0000 (Coordinated Universal Time)

    @PhantomCracker
    Copy link

    /assign

    @gentlementlegen
    Copy link
    Member

    This issue depends on ubiquity/pay.ubq.fi#110, since it changes the logic to fetch the permits.

    @rndquu
    Copy link
    Member Author

    rndquu commented Feb 19, 2024

    This issue depends on ubiquity/pay.ubq.fi#110, since it changes the logic to fetch the permits.

    Thank you, updated the description

    @gentlementlegen
    Copy link
    Member

    /start

    @gentlementlegen
    Copy link
    Member

    For unclaimed permits, I am currently displaying UNCLAIMED in the tx column, and I disabled the links for the tx and amount columns, to avoid having links redirecting to 404 pages. Please let me know if you desire a different behavior.

    @0x4007
    Copy link
    Member

    0x4007 commented Feb 22, 2024

    For unclaimed permits, I am currently displaying UNCLAIMED in the tx column, and I disabled the links for the tx and amount columns, to avoid having links redirecting to 404 pages. Please let me know if you desire a different behavior.

    It should be null in the database, and not say anything in the UI.

    @gentlementlegen
    Copy link
    Member

    The request to the new repo is ready at #2

    @molecula451 molecula451 transferred this issue from ubiquity/pay.ubq.fi Mar 3, 2024
    @0x4007
    Copy link
    Member

    0x4007 commented Mar 5, 2024

    We need the labels restored before the payment can be made.

    @FernandVEYRIER how long did it take we can just use your time input

    @0x4007 0x4007 added good first issue Good for newcomers Priority: 2 (Medium) and removed good first issue Good for newcomers labels Mar 5, 2024
    @gentlementlegen
    Copy link
    Member

    @pavlovcik Took < 2 hours, we spent more time reverting changes again and again as we discussed in the original PR here haha ubiquity/pay.ubq.fi#172

    @molecula451
    Copy link
    Member

    here is:

    image_2024-03-04_233533086

    @0x4007
    Copy link
    Member

    0x4007 commented Mar 5, 2024

    Haha we did it at the same time. I'll just add a little cause of the real world feedback of how long it took and usually F is fast

    @molecula451
    Copy link
    Member

    Haha we did it at the same time. I'll just add a little cause of the real world feedback of how long it took and usually F is fast

    indeed, haha re-do to < 4 hours

    @0x4007 0x4007 closed this as completed in #2 Mar 5, 2024
    Copy link

    ubiquibot bot commented Mar 5, 2024

    + Evaluating results. Please wait...

    Copy link

    ubiquibot bot commented Mar 5, 2024

    [ 13.6 WXDAI ]

    @pavlovcik
    Contributions Overview
    ViewContributionCountReward
    IssueComment49.7
    ReviewComment23.9
    Conversation Incentives
    CommentFormattingRelevanceReward
    You should be working on a draft pull request. ...
    0.90.390.9
    > For unclaimed permits, I am currently displaying `UNCLAIMED` i...
    3.4
    code:
      count: 2
      score: "2"
      words: 2
    
    0.283.4
    We need the labels restored before the payment can be made.

    @f...

    2.40.492.4
    Haha we did it at the same time. I'll just add a little cause of...
    30.23
    > Got the error

    Error: 🧨 Failed: Resource not acc...</a></h6></td><td><details><summary>2.4</summary>
    
    code:
      count: 2
      score: "2"
      words: 1
    
    0.212.4
    Merge conflict so can't merge but once that's resolved I think j...
    1.50.6051.5

    [ 15.35 WXDAI ]

    @PhantomCracker
    Contributions Overview
    ViewContributionCountReward
    IssueComment715.35
    Conversation Incentives
    CommentFormattingRelevanceReward
    Can we set the price so we can assign this? Also, @rndquu we sh...
    2.20.212.2
    Work in progress here, I think today I will finish it...
    1.10.741.1
    @rndquu can I have the etherscan API and RPC url?...
    10.591
    @rndquu I am not sure what I do wrong here... > You are supposed to be on the `/audit` path

    Can you be more...

    5.45

    code:
      count: 1
      score: "0.25"
      words: 1
    
    0.165.45
    I guess that today I will release the PR :) I really hope so...
    1.30.341.3
    Ok, I will open it now....
    0.60.650.6

    [ 262.6 WXDAI ]

    @FernandVEYRIER
    Contributions Overview
    ViewContributionCountReward
    IssueTask1200
    IssueComment40
    IssueComment412.2
    ReviewComment225.2
    ReviewComment225.2
    Conversation Incentives
    CommentFormattingRelevanceReward
    This issue depends on https://github.com/ubiquity/pay.ubq.fi/iss...
    -0.55-
    For unclaimed permits, I am currently displaying `UNCLAIMED` in ...
    -
    code:
      count: 1
      score: "0"
      words: 1
    
    0.44-
    The request to the new repo is ready at https://github.com/ubiqu...
    -0.22-
    @pavlovcik Took < 2 hours, we spent more time reverting changes ...
    -0.37-
    This issue depends on https://github.com/ubiquity/pay.ubq.fi/iss...
    2.20.552.2
    For unclaimed permits, I am currently displaying `UNCLAIMED` in ...
    5.1
    code:
      count: 1
      score: "1"
      words: 1
    
    0.445.1
    The request to the new repo is ready at https://github.com/ubiqu...
    1.80.221.8
    @pavlovcik Took < 2 hours, we spent more time reverting changes ...
    3.10.373.1
    Got the error ``` Error: 🧨 Failed: Resource not accessible by...
    16.4
    code:
      count: 2
      score: "2"
      words: 1
    
    0.1516.4
    It seems that there is a `permissions: write-all` in the Action....
    8.8
    code:
      count: 2
      score: "2"
      words: 3
    
    0.498.8
    Got the error ``` Error: 🧨 Failed: Resource not accessible by...
    16.4
    code:
      count: 2
      score: "2"
      words: 1
    
    0.1516.4
    It seems that there is a `permissions: write-all` in the Action....
    8.8
    code:
      count: 2
      score: "2"
      words: 3
    
    0.498.8

    [ 0.9 WXDAI ]

    @molecula451
    Contributions Overview
    ViewContributionCountReward
    IssueComment20.9
    Conversation Incentives
    CommentFormattingRelevanceReward
    here is:

    ![image_2024-03-04_233533086](https://github.com/ubi...

    0.20.230.2
    > Haha we did it at the same time. I'll just add a little cause ...
    0.70.080.7

    [ 4.6 WXDAI ]

    @devpanther
    Contributions Overview
    ViewContributionCountReward
    IssueComment24.6
    Conversation Incentives
    CommentFormattingRelevanceReward
    > @rndquu I am not sure what I do wrong here...

    You are supp...

    1.9

    code:
      count: 1
      score: "1"
      words: 1
    
    0.121.9
    > > You are supposed to be on the `/audit` path > > Can you be ...
    2.7
    code:
      count: 2
      score: "2"
      words: 6
    
    0.222.7

    [ 2.5 WXDAI ]

    @gitcoindev
    Contributions Overview
    ViewContributionCountReward
    ReviewComment12.5
    Conversation Incentives
    CommentFormattingRelevanceReward
    > Knip CI is failing but I don't think it should block this PR f...
    2.50.7352.5

    [ 11.6 WXDAI ]

    @rndquu
    Contributions Overview
    ViewContributionCountReward
    IssueSpecification18.8
    IssueComment32.8
    Conversation Incentives
    CommentFormattingRelevanceReward
    Depends on https://github.com/ubiquity/pay.ubq.fi/issues/100, ht...
    8.8
    a:
      count: 1
      score: "1"
      words: 2
    
    18.8
    > Also, @rndquu we should show all the issues that are closed, r...
    0.20.250.2
    > @rndquu can I have the etherscan API and RPC url?

    Check the...

    1.6

    a:
      count: 1
      score: "1"
      words: 1
    
    0.411.6
    > This issue depends on ubiquity/pay.ubq.fi#110, since it change...
    10.611

    @0x4007
    Copy link
    Member

    0x4007 commented Mar 5, 2024

    Looks like issue specification multiplier is not being applied. I think none of the multipliers work on the existing comment-incentives because also relevance isnt being applied to the final score. That's too bad. Looking forward to upgrading to the next version!

    https://github.com/ubiquity/ubiquibot-config/blob/development/.github/ubiquibot-config.yml#L15

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment