Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: fetch permits from database #2

Merged
merged 3 commits into from
Mar 5, 2024
Merged

feat: fetch permits from database #2

merged 3 commits into from
Mar 5, 2024

Conversation

gentlementlegen
Copy link
Member

Resolves #111

This was referenced Mar 2, 2024
Closed
Closed
@ubiquity-os-deployer
Copy link

ubiquity-os-deployer bot commented Mar 2, 2024 •
edited
Loading

@gentlementlegen
Copy link
Member Author

Got the error

Error: 🧨 Failed: Resource not accessible by integration
Error: 📚 Stack: HttpError: Resource not accessible by integration
    at file:///home/runner/work/_actions/Codex-/knip-reporter/v2/dist/index.mjs:18847:26
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async createCheck (file:///home/runner/work/_actions/Codex-/knip-reporter/v2/dist/index.mjs:21997:[20](https://github.com/ubiquity/audit.ubq.fi/actions/runs/8120352504/job/22197453898?pr=2#step:5:21))
    at async createCheckId (file:///home/runner/work/_actions/Codex-/knip-reporter/v2/dist/index.mjs:22174:15)
    at async timeTask (file:///home/runner/work/_actions/Codex-/knip-reporter/v2/dist/index.mjs:22314:18)
    at async run3 (file:///home/runner/work/_actions/Codex-/knip-reporter/v2/dist/index.mjs:28085:17)
Error: HttpError: Resource not accessible by integration

in the build. Probably missing permissions in the Action file.

@0x4007
Copy link
Member

0x4007 commented Mar 2, 2024

Got the error

Error: 🧨 Failed: Resource not accessible by integration
Error: 📚 Stack: HttpError: Resource not accessible by integration
    at file:///home/runner/work/_actions/Codex-/knip-reporter/v2/dist/index.mjs:18847:26
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async createCheck (file:///home/runner/work/_actions/Codex-/knip-reporter/v2/dist/index.mjs:21997:[20](https://github.com/ubiquity/audit.ubq.fi/actions/runs/8120352504/job/22197453898?pr=2#step:5:21))
    at async createCheckId (file:///home/runner/work/_actions/Codex-/knip-reporter/v2/dist/index.mjs:22174:15)
    at async timeTask (file:///home/runner/work/_actions/Codex-/knip-reporter/v2/dist/index.mjs:22314:18)
    at async run3 (file:///home/runner/work/_actions/Codex-/knip-reporter/v2/dist/index.mjs:28085:17)
Error: HttpError: Resource not accessible by integration

in the build. Probably missing permissions in the Action file.

@gitcoindev please prioritize this

@gentlementlegen
Copy link
Member Author

It seems that there is a permissions: write-all in the Action. Maybe the settings of the repo take over, I cannot have access to them, but according to the logs the permissions were:

GITHUB_TOKEN Permissions
  Actions: read
  Checks: read
  Contents: read
  Deployments: read
  Discussions: read
  Issues: read
  Metadata: read
  Packages: read
  Pages: read
  PullRequests: read
  RepositoryProjects: read
  SecurityEvents: read
  Statuses: read

which does not provide write permissions.

@0x4007 0x4007 mentioned this pull request Mar 2, 2024
Closed
@gentlementlegen gentlementlegen requested review from 0x4007 and rndquu March 4, 2024 04:36
rndquu
rndquu approved these changes Mar 4, 2024
View reviewed changes
Copy link
Member

@rndquu rndquu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Knip CI is failing but I don't think it should block this PR from merging

0x4007
0x4007 reviewed Mar 4, 2024
View reviewed changes
static/index.html
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting looks wrong here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed my indent settings that seemed different from the ones used in the project.

@gitcoindev
Copy link

Knip CI is failing but I don't think it should block this PR from merging

Yes, I agree, please ignore Knip CI failures for now. I will fix the Knip CI permission this week, after staking issue solution is finalized.

@0x4007
Copy link
Member

0x4007 commented Mar 4, 2024

Merge conflict so can't merge but once that's resolved I think just merge

@gentlementlegen
chore: fixed indent for index.html
92e7dc8
@gentlementlegen
Merge remote-tracking branch 'ubi/development' into feat/display-uncl…
737b76b 
…aimed-permits

# Conflicts:
#	.gitignore
#	static/scripts/audit-report/audit.ts
@gentlementlegen gentlementlegen requested a review from 0x4007 March 5, 2024 03:15
@0x4007 0x4007 merged commit 08fba85 into ubiquity:development Mar 5, 2024
1 of 2 checks passed
@gentlementlegen gentlementlegen deleted the feat/display-unclaimed-permits branch March 5, 2024 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rndquu rndquu rndquu approved these changes

@0x4007 0x4007 0x4007 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

audit dApp: Show issues with unclaimed permits
4 participants
@gentlementlegen @0x4007 @gitcoindev @rndquu