feat: support for gnosis chain #76

Venoox · 2023-06-19T17:07:39Z

This approach determines chain id based on the token, DAI for mainnet and WXDAI for gnosis.

Maybe a better approach would be including chain id in the URL parameter when generating a claim url on the bot, which would be cleaner in my opinion.

Resolves #69

fixed explorer url added gnosis rpc

Venoox · 2023-06-19T17:09:08Z

static/scripts/constants.ts

+export const chainRpc = {
+  "0x1": "https://rpc-pay.ubq.fi/v1/mainnet",
+  "0x5": "https://rpc-pay.ubq.fi/v1/goerli",
+  "0x64": "https://rpc.gnosischain.com",


do we have a rpc for gnosis chain?

We do not have an internal one for Gnosis Chain. We currently do not have plans to make one yet, unless we can use a ready-made service like Cloudflare's (but they do not support Gnosis Chain last I checked.)

0x4007 · 2023-06-19T17:44:56Z

Maybe a better approach would be including chain id in the URL parameter when generating a claim url on the bot, which would be cleaner in my opinion.

I agree I think that this is a good idea. I can add this to the bounty specification.

…twork also refactored

Venoox · 2023-06-19T20:37:44Z

Submitted a PR for chainID in permit url: ubiquity/ubiquibot#417

0x4007 · 2023-06-21T10:17:23Z

static/scripts/constants.ts

+export enum Chain {
+  Mainnet = "0x1",
+  Goerli = "0x5",
+  Gnosis = "0x64",
+}


Seems more proper. Nice code quality.

Please rename all references of "chain id" to "network id"

This is because I don't believe it is semantically correct to refer to rollups as "chains"

0x4007 · 2023-06-21T10:17:43Z

static/scripts/pay.ts

  createToast("error", `Error: ${errorMessage}`);
 };

 const connectWallet = async (): Promise<JsonRpcSigner> => {
  try {
-    const provider = new ethers.providers.Web3Provider(window.ethereum, "any");
+    const provider = new ethers.providers.Web3Provider((window as any).ethereum, "any");


Don't use any try making or using a Window type.

0x4007

The code looks high quality. I can't test from my phone but what I read through looks good.

@0xcodercrane I thought we have continuous deployment set up on all of our repos?

Strange that the last run was 2 months ago https://github.com/ubiquity/pay.ubq.fi/actions/workflows/continuous-deploy.yml of our continuous deploy CI: https://github.com/ubiquity/pay.ubq.fi/blob/main/.github/workflows/continuous-deploy.yml

0x4007 · 2023-06-23T07:32:56Z

static/scripts/constants.ts

+
+export const chainRpc = {
+  [Chain.Mainnet]: "https://rpc-pay.ubq.fi/v1/mainnet",
+  [Chain.Goerli]: "https://rpc-pay.ubq.fi/v1/goerli",


I don't think this is set up nor is it easy to do so we will need to fetch from chainlist.org possibly.

0x4007 · 2023-06-23T07:33:43Z

static/scripts/draw.ts

Thanks for adding types to this. I wrote this code like five years ago 😂

0x4007 · 2023-06-24T09:20:14Z

@0xcodercrane I thought we have continuous deployment set up on all of our repos?

I see that it is designed to not deploy when pull request opened to main so I just changed our default branch to development and changed this pull request base branch to development.

https://github.com/ubiquity/pay.ubq.fi/actions/runs/5363612713/jobs/9731306668 @0xcodercrane it doesn't work

Is it because it is conflicting with the Cloudflare Pages deployment I set up in my personal account?

Venoox · 2023-06-24T11:23:42Z

@pavlovcik The workflow tries to create a project named pay.ubq.fi and that's invalid name because it has dots.

0x4007 · 2023-06-24T11:47:27Z

Thanks for the clarification @Venoox! We'll need to substitute with valid characters, like hyphens.

0x4007 · 2023-06-24T11:55:10Z

Can you push a commit to try it out?

https://github.com/ubiquity/pay.ubq.fi/actions/runs/5364165850/jobs/9732187832

Just realized Cloudflare generated an invalid URL or some issue with the SSL certificate because I can't load the linked URL https://41fa25b0.pay-ubq-fi-bxp.pages.dev/

Venoox · 2023-06-24T13:58:27Z

@pavlovcik it seems that https://41fa25b0.pay-ubq-fi-bxp.pages.dev/out/styles/app.css is not loading the css but the html file, that usually occurs because the file does not exist so Cloudflare falls back to index.html.

I've looked at the workflow file again and it seems that the build command is not run, that's why /out directory doesn't exist.

0x4007 · 2023-06-26T19:09:47Z

@Venoox I asked @rndquu to help with fixing the continuous deployment so that we can complete our review. Thanks for your patience.

rndquu · 2023-06-27T12:02:38Z

@Venoox pls merge the latest development branch

0x4007 · 2023-06-28T18:51:51Z

@rndquu following up

rndquu · 2023-06-29T00:37:24Z

@Venoox pls merge the latest development branch

rndquu · 2023-06-29T12:14:25Z

this PR can be checked here: https://f08f45ad.pay-ubq-fi-bxp.pages.dev/

I will add posting of deployment URLs today

rndquu · 2023-06-29T22:13:14Z

@Venoox one more time pls merge the development branch

github-actions · 2023-06-30T08:21:45Z

https://b03659a9.pay-ubq-fi-bxp.pages.dev

Venoox · 2023-06-30T19:26:58Z

can we get this merged because I have #73 ready but it depends on this code

0x4007 · 2023-07-03T06:29:21Z

The DOM seems to have gotten all messed up somehow, check the bottom of my screenshot. Upon mouseover the entire table to claim disappears as well.

I generated a test permit.

And I forgot to include the network ID in the url and the error message is unclear. Can you handle this error in the toaster? You can say something like the network ID needs to be passed in. Alternatively you can default to mainnet? I was quickly going through the source code and couldn't figure out what the query parameter's property name is.

The craziest part is that upon mouseover the entire page is an invalid link with embedded HTML which obviously isn't good.

0x4007

Please test before your next revisions with the encoded permit included in my test permit link to see the mouse-over DOM breaking issue which must be fixed.

Venoox · 2023-07-03T10:10:32Z

@pavlovcik this is an issue with deployment because commit.txt does not exist and cloudflare pages returns the index.html which breaks everything

rndquu · 2023-07-03T20:21:22Z

@pavlovcik this is an issue with deployment because commit.txt does not exist and cloudflare pages returns the index.html which breaks everything

I'll check it today

rndquu · 2023-07-04T12:44:06Z

@pavlovcik this is an issue with deployment because commit.txt does not exist and cloudflare pages returns the index.html which breaks everything

pls merge the development branch, commit sha from the commit.txt file should appear

github-actions · 2023-07-04T16:33:16Z

https://4bbbf7fb.pay-ubq-fi-bxp.pages.dev

rndquu · 2023-07-04T16:41:17Z

@Venoox could you ensure that all of the errors are solved? If so then pls re-request a review

Venoox · 2023-07-04T17:09:52Z

everything looks good now

0x4007 · 2023-07-04T17:18:22Z

Just tested with the Ethereum mainnet permit, and connected to Gnosis Chain and it did what was expected.

Now I need to test the opposite. Gnosis Chain permit.

I need clarity on the query parameter to test the Gnosis Chain permit.

Venoox · 2023-07-04T19:33:39Z

the query parameter is chainId so for gnosis chain it is: permit

0x4007 · 2023-07-05T05:22:04Z

the query parameter is chainId so for gnosis chain it is: permit

This is looking fantastic. Thanks!

Please be sure to resolve all of the conversation points in the files changed view before we merge this, including renaming all instances of "chain" to "network" https://github.com/ubiquity/pay.ubq.fi/pull/76/files#r1242357293

Can you rename the query parameter to ?network=100 instead of using hexadecimal? Alternatively I suppose it wouldn't be too difficult to make the UI understand that network IDs prefixed with 0x are hexadecimal and should be parsed as base16.

I also want to give a small bonus when this is completed for 1. helping us debug the deployment issue and 2. the high quality code!

0x4007 · 2023-07-05T05:39:09Z

static/scripts/constants.ts

+};
+
+export const chainRpc = {
+  [Chain.Mainnet]: "https://rpc-pay.ubq.fi/v1/mainnet",


I think this should be private. Perhaps this also can be fetched from chainlist etc. We can make a new bounty for this in order to close the current issue out faster.

What do you mean by private?

We should not share this RPC endpoint with the public because it can be abused (we don't have rate limits, API keys etc.)

This originally was set up strictly for our internal tooling because we would hammer the RPC with a LOT of network requests (public RPC endpoints would rate limit us.)

github-actions · 2023-07-05T06:50:12Z

https://48eef5d9.pay-ubq-fi-bxp.pages.dev

Venoox · 2023-07-05T06:51:08Z

Now it's changed to network. Also query parameter network now supports hex and decimal

0x4007 · 2023-07-05T08:35:42Z

I also want to give a small bonus when this is completed for 1. helping us debug the deployment issue and 2. the high quality code!

https://gnosisscan.io/tx/0xa7973600480751779489ca1f816e26f68d7f30653c2cdebcd3cbe8bb7f3bdc65

Thanks @Venoox

Venoox · 2023-07-05T17:09:48Z

@pavlovcik thanks, I appreciate it!

feat: support for gnosis chain

d40d631

fixed explorer url added gnosis rpc

Venoox commented Jun 19, 2023

View reviewed changes

0x4007 mentioned this pull request Jun 19, 2023

Gnosis Chain Support #69

Closed

4 tasks

feat: detect chain based on URL parameter, added request to change ne…

7e51a66

…twork also refactored

fix: error

6b17e49

Venoox marked this pull request as ready for review June 20, 2023 17:09

0x4007 reviewed Jun 21, 2023

View reviewed changes

feat: add window types

6b4dbca

Venoox requested a review from 0x4007 June 22, 2023 21:40

0x4007 approved these changes Jun 23, 2023

View reviewed changes

rndquu mentioned this pull request Jun 23, 2023

Create a reusable web deploy workflow ubiquity/ts-template#6

Closed

0x4007 changed the base branch from main to development June 24, 2023 09:19

0x4007 mentioned this pull request Jun 24, 2023

fix: convert periods to hyphens in repo names #78

Merged

Merge branch 'development' into improvements

f33cb89

Merge branch 'development' into improvements

a801da4

Merge branch 'development' into improvements

277328c

ubiquity deleted a comment from github-actions bot Jun 30, 2023

0x4007 requested changes Jul 3, 2023

View reviewed changes

Venoox mentioned this pull request Jul 4, 2023

Create UI for permit2 nonce invalidation #73

Closed

Venoox added 2 commits July 4, 2023 18:29

Merge branch 'development' into improvements

9ad9e69

fix: default chain is ethereum mainnet

8f86fa2

Venoox requested a review from 0x4007 July 4, 2023 17:09

0x4007 mentioned this pull request Jul 5, 2023

Payment Permit URL Must Specify Network ID Now ubiquity/ubiquibot#460

Closed

0x4007 reviewed Jul 5, 2023

View reviewed changes

refactor: rename chain to network

499807f

0x4007 approved these changes Jul 5, 2023

View reviewed changes

0x4007 merged commit ed640bd into ubiquity:development Jul 5, 2023

feat: support for gnosis chain #76

feat: support for gnosis chain #76

Conversation

Venoox commented Jun 19, 2023 • edited Loading

Venoox Jun 19, 2023

Choose a reason for hiding this comment

0x4007 Jun 19, 2023

Choose a reason for hiding this comment

0x4007 commented Jun 19, 2023

Venoox commented Jun 19, 2023

0x4007 Jun 21, 2023

Choose a reason for hiding this comment

0x4007 Jun 26, 2023 • edited Loading

Choose a reason for hiding this comment

0x4007 Jun 21, 2023 • edited Loading

Choose a reason for hiding this comment

0x4007 left a comment • edited Loading

Choose a reason for hiding this comment

0x4007 Jun 23, 2023

Choose a reason for hiding this comment

0x4007 Jun 23, 2023

Choose a reason for hiding this comment

0x4007 commented Jun 24, 2023 • edited Loading

Venoox commented Jun 24, 2023

0x4007 commented Jun 24, 2023

0x4007 commented Jun 24, 2023 • edited Loading

Venoox commented Jun 24, 2023

0x4007 commented Jun 26, 2023

rndquu commented Jun 27, 2023

0x4007 commented Jun 28, 2023

rndquu commented Jun 29, 2023

rndquu commented Jun 29, 2023

rndquu commented Jun 29, 2023

github-actions bot commented Jun 30, 2023

Venoox commented Jun 30, 2023

0x4007 commented Jul 3, 2023 • edited Loading

0x4007 left a comment

Choose a reason for hiding this comment

Venoox commented Jul 3, 2023

rndquu commented Jul 3, 2023

rndquu commented Jul 4, 2023

github-actions bot commented Jul 4, 2023

rndquu commented Jul 4, 2023

Venoox commented Jul 4, 2023

0x4007 commented Jul 4, 2023 • edited Loading

Venoox commented Jul 4, 2023 • edited Loading

0x4007 commented Jul 5, 2023 • edited Loading

0x4007 Jul 5, 2023

Choose a reason for hiding this comment

Venoox Jul 5, 2023

Choose a reason for hiding this comment

0x4007 Jul 5, 2023 • edited Loading

Choose a reason for hiding this comment

github-actions bot commented Jul 5, 2023

Venoox commented Jul 5, 2023

0x4007 commented Jul 5, 2023

Venoox commented Jul 5, 2023

Venoox commented Jun 19, 2023 •

edited

Loading

0x4007 Jun 26, 2023 •

edited

Loading

0x4007 Jun 21, 2023 •

edited

Loading

0x4007 left a comment •

edited

Loading

0x4007 commented Jun 24, 2023 •

edited

Loading

0x4007 commented Jun 24, 2023 •

edited

Loading

0x4007 commented Jul 3, 2023 •

edited

Loading

0x4007 commented Jul 4, 2023 •

edited

Loading

Venoox commented Jul 4, 2023 •

edited

Loading

0x4007 commented Jul 5, 2023 •

edited

Loading

0x4007 Jul 5, 2023 •

edited

Loading