fix: make tracking property optional

ubiquity · Jun 16, 2024 · 4fbe2f1 · 4fbe2f1
1 parent e3cd0f0
commit 4fbe2f1
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 3 deletions.
diff --git a/tests/rpc-handler.test.ts b/tests/rpc-handler.test.ts
@@ -96,6 +96,9 @@ describe("RPCHandler", () => {
  yes: function (rpc: RpcType) {
  return true;
  },
+ undefined: function (rpc: RpcType) {
+ return true;
+ },
  };
 
  for (const [trackingOption, filterFunction] of Object.entries(filterFunctions)) {
@@ -111,7 +114,11 @@ describe("RPCHandler", () => {
  });
 
  const rpcHandlerConfig = { ...testConfig };
- rpcHandlerConfig.tracking = trackingOption as Tracking;
+ if (trackingOption == "undefined") {
+ delete rpcHandlerConfig.tracking;
+ } else {
+ rpcHandlerConfig.tracking = trackingOption as Tracking;
+ }
  const handler = new RPCHandler(rpcHandlerConfig);
  await handler.testRpcPerformance();
  const runtime = handler.getRuntimeRpcs();

diff --git a/types/handler.ts b/types/handler.ts
@@ -38,7 +38,7 @@ export type HandlerConstructorConfig = {
  cacheRefreshCycles: number | null;
  runtimeRpcs: string[] | null;
  rpcTimeout: number | null;
- tracking: Tracking;
+ tracking?: Tracking;
 };
 
 export type NetworkRPCs = typeof networkRpcs;

diff --git a/types/rpc-handler.ts b/types/rpc-handler.ts
@@ -25,7 +25,7 @@ export class RPCHandler implements HandlerInterface {
 
  constructor(config: HandlerConstructorConfig) {
  this._networkId = config.networkId;
- this._networkRpcs = this.filterNetworks(networkRpcsOriginal[this._networkId], config.tracking);
+ this._networkRpcs = this.filterNetworks(networkRpcsOriginal[this._networkId], config.tracking || "yes");
  this._networkName = networkNames[this._networkId];
  this._initialize(config);
  }