Disable the Non-null Assertion Operator with Linting

[0x4007]

There's a lot of abuse in our codebases with contributors using "!"

Example:

let element: HTMLElement | null = document.getElementById('test');

// This would throw a TypeScript error without the "!" because element could be null
let value: string = element!.innerText;

Enforce that this can not pass our linters.

[b4s36t4]

@pavlovcik Rule should be enabled in this repo only right? https://github.com/ubiquity/ubiquibot

[ubiquibot]

Available commands

- /assign: Assign the origin sender to the issue automatically.
- /unassign: Unassign the origin sender from the issue automatically.
- /help: List all available commands.
- /payout: Disable automatic payment for the issue.
- /multiplier: Set bounty multiplier (for treasury)
- /allow: Set access control. (Admin Only)
- /wallet: <WALLET_ADDRESS | ENS_NAME>: Register the hunter's wallet address. 
  ex1: /wallet 0xf39fd6e51aad88f6f4ce6ab8827279cfffb92266 
  ex2: /wallet vitalik.eth

@b4s36t4

[0x4007]

In this template. We have to manually fix every issue based on the linter settings set up here.

[b4s36t4]

https://github.com/ubiquity/ubiquity-dollar/blob/82077e295e996c7b8f774ec3ded73ca5637ca2af/utils/kebabalize-filenames.ts#L36

https://github.com/ubiquity/pay.ubq.fi/blob/bca42a52e57cf2bc7aa4390f909f891005e4ba23/static/scripts/pay.ts#L58

Found only these two place where non-null assertion is being used. Do you know any places or specific repo to have the same?

If not ready to pickup this.

[0x4007]

I was cleaning a handful of them yesterday in pay.ubq.fi repository so I'm not sure.

Either way, they shouldn't be used in almost every example that I've come across.

Yes we should disable in our linter.

[baibhavKumar1]

@pavlovcik , we can disable this in the linter, but what's alternate for "!" in codebase in your opinion? Should we change it with "?" mark?

[ubiquibot]

Available commands

- /start: Assign the origin sender to the issue automatically.
- /stop: Unassign the origin sender from the issue automatically.
- /help: List all available commands.
- /autopay: Toggle automatic payment for the completion of the current issue.
- /query: Comments the users multiplier and address
- /multiplier: Set the bounty payout multiplier for a specific contributor, and provide the reason for why. 
  example usage: "/wallet @user 0.5 'Multiplier reason'"
- /allow: Set access control. (Admin Only)
- /wallet: <WALLET_ADDRESS | ENS_NAME>: Register the hunter's wallet address. 
  ex1: /wallet 0x0000000000000000000000000000000000000000
  ex2: /wallet vitalik.eth

@Wholesomebruh

[0x4007]

@pavlovcik , we can disable this in the linter, but what's alternate for "!" in codebase in your opinion? Should we change it with "?" mark?

Correct typings. Just never use any.

It's straightforward if you know typings. Just more work with certain complex objects.

[3scava1i3r]

@pavlovcik , we can disable this in the linter, but what's alternate for "!" in codebase in your opinion? Should we change it with "?" mark?

Correct typings. Just never use any.

It's straightforward if you know typings. Just more work with certain complex objects.

In this template or every repo by ubiquity?

[ubiquibot]

Available commands

- /start: Assign the origin sender to the issue automatically.
- /stop: Unassign the origin sender from the issue automatically.
- /help: List all available commands.
- /autopay: Toggle automatic payment for the completion of the current issue.
- /query: Comments the users multiplier and address
- /ask: Ask a technical question to the Ubiquity AI. 
  example usage: "/ask How do I do X?"
- /multiplier: Set the bounty payout multiplier for a specific contributor, and provide the reason for why. 
  example usage: "/wallet @user 0.5 'Multiplier reason'"
- /allow: Set access control. (Admin Only)
- /wallet: <WALLET_ADDRESS | ENS_NAME>: Register the hunter's wallet address. 
  ex1: /wallet 0x0000000000000000000000000000000000000000
  ex2: /wallet vitalik.eth

@3scava1i3r

[0x4007]

@pavlovcik , we can disable this in the linter, but what's alternate for "!" in codebase in your opinion? Should we change it with "?" mark?

Correct typings. Just never use any.

It's straightforward if you know typings. Just more work with certain complex objects.

In this template or every repo by ubiquity?

Both!

[ubiquibot]

+ Evaluating results. Please wait...

[ubiquibot]

+ Evaluating results. Please wait...

[ubiquibot]

@pavlovcik the deadline is at 2024-01-23T10:27:00.632Z

[ubiquibot]

! action has an uncaught error