This repository has been archived by the owner on Sep 19, 2024. It is now read-only.
hotfix of permit check #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ubiquibot-staging ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
rndquu
approved these changes
May 29, 2023
0x4007
reviewed
May 29, 2023
There was a problem hiding this comment.
I linked another bounty.
To clarify, I believe that the order of the checks matter so that the bot can provide the most relevant warning/error message in the comment for why the permit generation was aborted.
In this reference scenario, the bot should first check if the issue was closed as completed. If it is not closed as completed, then the bot should cite that as the reason the permit was not generated above any other reason.
I suppose we should come up with a list of all the reasons and put them in a single ordered list in a bounty in order to provide the most relevant warning/error message.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.