-
Notifications
You must be signed in to change notification settings - Fork 61
feat: add repo specific wallet support #747
Conversation
✅ Deploy Preview for ubiquibot-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Please demo this working by configuring your test org and showing a repo specific permit and a generic org permit. |
do i have to remove merged configs or no, i dont really get why not if no |
the failed attempts were because i was dumb while trying to generate a key |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are you adding typescript interfaces?
Should I only modify wide repo config? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can delete org config type because now repo and org configs have the same format
@whilefoo done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you post QA based on the latest changes? one permit with repo specific wallet and one permit with org wallet
@whilefoo how to setup org wallet |
BeanieMen#7 for repo wallet |
me505-qa/ubiquibot#1 org permit |
@whilefoo idk how to prove it to you that this is a org permit but this is it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The codebase looks good. will wait for @me505.
What do you want me for? |
@pavlovcik can you review this? |
oh sorry my bad. I wanted to tag whilefoo lol |
Can you guys verify the following scenarios hold true with this implementation?
|
I just tested and can confirm |
Resolves #719