Skip to content
This repository has been archived by the owner on Sep 19, 2024. It is now read-only.

feat: add repo specific wallet support #747

Merged
merged 7 commits into from
Sep 19, 2023

Conversation

BeanieMen
Copy link
Contributor

Resolves #719

@netlify
Copy link

netlify bot commented Sep 10, 2023

Deploy Preview for ubiquibot-staging ready!

Name Link
🔨 Latest commit d7d181f
🔍 Latest deploy log https://app.netlify.com/sites/ubiquibot-staging/deploys/650817df76cbdb0008c42264
😎 Deploy Preview https://deploy-preview-747--ubiquibot-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@0x4007
Copy link
Member

0x4007 commented Sep 10, 2023

Please demo this working by configuring your test org and showing a repo specific permit and a generic org permit.

@BeanieMen
Copy link
Contributor Author

do i have to remove merged configs or no, i dont really get why not if no

@BeanieMen
Copy link
Contributor Author

@pavlovcik
BeanieMen#5

@BeanieMen
Copy link
Contributor Author

@BeanieMen
Copy link
Contributor Author

the failed attempts were because i was dumb while trying to generate a key

Copy link
Collaborator

@whilefoo whilefoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are you adding typescript interfaces?

@BeanieMen
Copy link
Contributor Author

Should I only modify wide repo config?

Copy link
Collaborator

@whilefoo whilefoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can delete org config type because now repo and org configs have the same format

src/utils/private.ts Outdated Show resolved Hide resolved
@BeanieMen
Copy link
Contributor Author

@whilefoo done

Copy link
Collaborator

@whilefoo whilefoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you post QA based on the latest changes? one permit with repo specific wallet and one permit with org wallet

@BeanieMen
Copy link
Contributor Author

@whilefoo how to setup org wallet

@whilefoo
Copy link
Collaborator

@whilefoo how to setup org wallet

it's private-key-encrypted field in org and repo config. you can generate a random one

@BeanieMen
Copy link
Contributor Author

BeanieMen#7 for repo wallet

@BeanieMen
Copy link
Contributor Author

me505-qa/ubiquibot#1 org permit

@BeanieMen
Copy link
Contributor Author

@whilefoo idk how to prove it to you that this is a org permit but this is it

0xcodercrane
0xcodercrane previously approved these changes Sep 18, 2023
Copy link
Contributor

@0xcodercrane 0xcodercrane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The codebase looks good. will wait for @me505.

@BeanieMen
Copy link
Contributor Author

What do you want me for?

@BeanieMen
Copy link
Contributor Author

@pavlovcik can you review this?

@0xcodercrane 0xcodercrane merged commit dba8308 into ubiquity:development Sep 19, 2023
9 checks passed
@0xcodercrane
Copy link
Contributor

What do you want me for?

oh sorry my bad. I wanted to tag whilefoo lol

@0x4007
Copy link
Member

0x4007 commented Sep 20, 2023

Can you guys verify the following scenarios hold true with this implementation?

  1. The org sets an org wallet; no repo wallet set; payouts generated from org wallet.
  2. The org sets an org wallet; repo wallet set; payouts generated from repo wallet.

@whilefoo
Copy link
Collaborator

Can you guys verify the following scenarios hold true with this implementation?

  1. The org sets an org wallet; no repo wallet set; payouts generated from org wallet.
  2. The org sets an org wallet; repo wallet set; payouts generated from repo wallet.

I just tested and can confirm

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable Support for Repository Specific Wallet
4 participants