635 remove unnecessary files from coverage

[eugenioclrc]

Resolves #635

In forge currently is impossible to ignore files, but there is a wayaround to tackle this issue.
Please view foundry-rs/foundry#2988 based on this comment foundry-rs/foundry#2988 (comment) i have setup a coverage.sh script to ignore tests, mocks and scriptint solidity files.

[0x4007]

Welcome to the DevPool from the DragonFly CTF leaderboard @eugenioclrc!

Some questions:

[zgorizzo69]

nice work that is what I had in mind ;)

[eugenioclrc]

Note for the future, it will be excellent to make this work;

diff --git a/.github/workflows/coverage-check.yml b/.github/workflows/coverage-check.yml
index 2b40567d..ef400b75 100644
--- a/.github/workflows/coverage-check.yml
+++ b/.github/workflows/coverage-check.yml
@@ -29,34 +29,7 @@ jobs:
       - name: Get development branch coverage
         id: coverage-development
         run: |
-          cd ./packages/contracts
-
-          # generates lcov.info
-          forge coverage --report lcov
-
-          # Foundry uses relative paths but Hardhat uses absolute paths.
-          # Convert absolute paths to relative paths for consistency.
-          sed -i -e 's/\/.*solidity.//g' lcov.info
-
-          # Merge lcov files
-          lcov \
-              --rc lcov_branch_coverage=1 \
-              --add-tracefile lcov.info \
-              --output-file merged-lcov.info
-
-          # Filter out node_modules, test, and mock files
-          lcov \
-              --rc lcov_branch_coverage=1 \
-              --remove merged-lcov.info \
-              --output-file filtered-lcov.info \
-              "*node_modules*" "*test*" "*mock*" "*scripts*"
-
-
-          # Generate summary
-          COVERAGE_DEVELOPMENT_OUTPUT=$(lcov \
-              --rc lcov_branch_coverage=1 \
-              --list filtered-lcov.info)
-
+          COVERAGE_DEVELOPMENT_OUTPUT=$(npm run coverage)
           echo COVERAGE=$(echo "${COVERAGE_DEVELOPMENT_OUTPUT}" | tail -n 1 | cut -d % -f 1 | cut -d \| -f 2) >> $GITHUB_OUTPUT
 
       - name: Checkout code in PR branch
@@ -65,33 +38,7 @@ jobs:
       - name: Get PR branch coverage
         id: coverage-pr
         run: |
-          cd ./packages/contracts
-
-          # generates lcov.info
-          forge coverage --report lcov
-
-          # Foundry uses relative paths but Hardhat uses absolute paths.
-          # Convert absolute paths to relative paths for consistency.
-          sed -i -e 's/\/.*solidity.//g' lcov.info
-
-          # Merge lcov files
-          lcov \
-              --rc lcov_branch_coverage=1 \
-              --add-tracefile lcov.info \
-              --output-file merged-lcov.info
-
-          # Filter out node_modules, test, and mock files
-          lcov \
-              --rc lcov_branch_coverage=1 \
-              --remove merged-lcov.info \
-              --output-file filtered-lcov.info \
-              "*node_modules*" "*test*" "*mock*" "*scripts*"
-
-
-          # Generate summary
-          COVERAGE_DEVELOPMENT_OUTPUT=$(lcov \
-              --rc lcov_branch_coverage=1 \
-              --list filtered-lcov.info)
+          COVERAGE_DEVELOPMENT_OUTPUT=$(npm run coverage)
           echo COVERAGE=$(echo "${COVERAGE_DEVELOPMENT_OUTPUT}" | tail -n 1 | cut -d % -f 1 | cut -d \| -f 2) >> $GITHUB_OUTPUT
 
       - name: Print coverages

[0x4007]

Is that pseudo code or why not just implement the suggestion as is?

[eugenioclrc]

Is that pseudo code or why not just implement the suggestion as is?

Npm run coverage should run all those lines, not sure why is not working on gh action

[0x4007]

You can link some GitHub action logs here and we might be able to help debug it.