feat: Algorithmic Market Operations for Collateral

[FibrinLab]

Resolves #611

Hello,
Forked from Frax and ERC 4626 compliant.
Increasing test coverage.
Comments Natspec.
Cannot get Ubiquibot to assign task to me.

Looking forward to review.
Thanks

[molecula451]

can you handle the changes, @FibrinLab ?

[FibrinLab]

can you handle the changes, @FibrinLab ?

Yes. Working on it. Adding a few more tests to increase coverage

[molecula451]

i must admit it's looking much better now

[0x4007]

Code style changes. Check our contributions guidelines in this repo.

[FibrinLab]

Code style changes. Check our contributions guidelines in this repo.

Its fixed

[molecula451]

nice but please refactor everything with underspace name_var_space, we use camelCase in the repo for naming @FibrinLab also it looks like the build it's failing

[gitcoindev]

Hi, I will also review once the build is fixed

Compiler run failed:
Error (6275): Source "src/dollar/interfaces/IAmo.sol" not found: File not found. Searched the following locations: "/home/runner/work/ubiquity-dollar/ubiquity-dollar/packages/contracts".
  --> src/dollar/libraries/LibDollarAmoMinter.sol:10:1:

[0x4007]

nice but please refactor everything with underspace name_var_space, we use camelCase in the repo for naming @FibrinLab also it looks like the build it's failing

I recently added a ton of linter rules in @ubiquity/ts-template

Perhaps they should be migrated to this repository. Unfortunately they are only configured for TypeScript but maybe there's a plugin for it to work with solidity.

[molecula451]

I recently added a ton of linter rules in @ubiquity/ts-template
Unfortunately they are only configured for typescript but maybe there's a plugin for it to work with solidity.

it does sound like a must-have implementation

[molecula451]

you are doing good but this is unnaceptable, we can't have this naming, e.g dollarValE18

[molecula451]

why do you want to refer to this naming like that? @FibrinLab

[FibrinLab]

I tried to stay consistent with the fork. I will just switch to simpler var names.

[rndquu]

@FibrinLab

There is the UbiquityPoolFacet contract where users can:

1. Deposit collateral tokens (LUSD for example) and get Dollar tokens
2. Redeem(burn) Dollar tokens in exchange for collateral

As a part of the current issue we should:

1. Implement AmoMinter contract (example) which is responsible for transferring unused collateral from UbiquityPool to AMO contracts. There is already special method for borrowing collateral assets which can be called only by the AmoMinter contract.
2. Implement 1 AMO strategy (example) and make it ERC-4626 compatible.

So in the end we should have a mechanism (set of contracts) where admin can transfer collateral tokens to one of the AMO strategies.

Right now AmoMinter and at least 1 AMO strategy contracts are not implemented.

[FibrinLab]

1. example

Thanks for the review. AMO minter is implemented. Adding a strategy.

[molecula451]

we want to have this one too @FibrinLab , do not leave the PR stale, it's good you update us

[FibrinLab]

we want to have this one too @FibrinLab , do not leave the PR stale, it's good you update us

Hello. Making final changes. Almost ready

[FibrinLab]

@molecula451 Here is the initial draft. Adding tests and comments.

[gitcoindev]

Hi @FibrinLab unfortunately this pull request seems to break a few CI checks. Could you please have a look at the failures and try to fix them or re-run if needed? The GitHub action results are available in above , I am pasting the links for reference:

Build & Test Details
Compare Test Coverage Details
Slither Analysis Details
Spell Check Details

[molecula451]

@FibrinLab please fix all the build erros, you can do yarn build:all to build and make sure all build pass before commiting changes

[molecula451]

closing looks like the contributor lose interests in working on the issue