Only display tasks with price labels (or without, depending on env) #77

xno-miner · 2024-08-15T15:52:57Z

Filter issues with price label when loading issue previews in src/home/fetch-github/fetch-issues-preview.ts.

xno-miner · 2024-08-15T17:20:27Z

This part is done (it works for me locally at least).

The amount of issues that can be fetched with a single request is 30 (default) or 100 (max). There are currently 92 issues in the devpool (including those without price label) so I implemented pagination to avoid future problems with the website.

package.json

src/home/fetch-github/fetch-issues-preview.ts

ubiquity-os-deployer · 2024-08-15T18:37:06Z

1fff162

1f2bd94

334442e

d296a84

6687fef

f360e4a

Co-authored-by: アレクサンダー.eth <4975670+0x4007@users.noreply.github.com>

xno-miner · 2024-08-17T19:14:30Z

I added an RFC enviromental variable. For the false value it works just as before. It normally wouldn't work for true value yet, but it almost does, because of the issues i accidentaly created. The only problem is it doesn't display any labels. This is becase the issues it's displaying don't have any (they're the ones i accidentally added with my bot). For the labels to be displayed, all issues in devpool-directory created by testbot6 need to be removed. After that, once the backend will be merged and the issues will be synced, the labels will be displayed correctly.

rndquu · 2024-08-19T13:31:24Z

@xno-miner Could you fix the tests https://github.com/ubiquity/work.ubq.fi/actions/runs/10434585610/job/28922040659?pr=77 ?

xno-miner · 2024-08-19T14:03:23Z

@xno-miner Could you fix the tests https://github.com/ubiquity/work.ubq.fi/actions/runs/10434585610/job/28922040659?pr=77 ?

Ok

xno-miner · 2024-08-19T22:26:02Z

@xno-miner Could you fix the tests

Seems like the tests were also failing in the main branch and have been fixed here: f14181a. I have added this commit to the branch.

0x4007 · 2024-08-27T02:38:32Z

@rndquu do you mind seeing this rfc project reviews through?

rndquu

@xno-miner

Pls resolve code conflicts
Getting this error when setting RFC=true in the .env file:

Pls fix

rndquu · 2024-08-27T15:28:57Z

build/esbuild-build.ts

@@ -29,6 +29,7 @@ export const esBuildContext: esbuild.BuildOptions = {
    SUPABASE_STORAGE_KEY: generateSupabaseStorageKey(),
    commitHash: execSync(`git rev-parse --short HEAD`).toString().trim(),
    NODE_ENV: process.env.NODE_ENV || "development",
+    IS_RFC: JSON.parse(process.env.RFC!)


It makes sense to provide a default value here in case process.env.RFC is empty, like process.env.RFC || false. This way we make it backwards compatible with already deployed version of work.ubq.fi.

cypress/e2e/devpool.cy.ts

rndquu · 2024-08-27T15:33:47Z

src/home/fetch-github/fetch-issues-preview.ts

@@ -71,7 +77,7 @@ export async function fetchIssuePreviews(): Promise<TaskNoFull[]> {
    }
  }

-  const tasks = freshIssues.map((preview: GitHubIssue) => ({
+  const tasks = freshIssues.filter((issue: GitHubIssue) => (issue.labels as GitHubLabel[]).some((label) => label.name.includes("Pricing")) == !IS_RFC).map((preview: GitHubIssue) => ({


How IS_RFC gets a value here? I mean that we define it here but don't assign it a value anywhere. Is it working?

env variables are passed in at build time

source: comments at the top of src/home/rendering/render-github-login-button.ts

xno-miner · 2024-08-28T14:32:43Z

2. Getting this error when setting `RFC=true` in the `.env` file:

Pls fix

The same error exists in the deployed version on https://work.ubq.fi. The error exists because some issue links include www. which causes the regex to not match. I will create a pull request in this repository separate from this one so it can be merged separately quicker.

xno-miner · 2024-08-28T15:06:39Z

The same error exists in the deployed version on https://work.ubq.fi. The error exists because some issue links include www. which causes the regex to not match. I will create a pull request in this repository separate from this one so it can be merged separately quicker.

I have created the PR: #86

xno-miner · 2024-09-22T19:21:01Z

Still waiting for review, @rndquu.
Here, as well as in ubiquity/devpool-directory#1250

.env.example

0x4007 · 2024-09-25T21:52:29Z

Is the idea to fork this repo and run rfc.ubq.fi off of it? They will need to be hosted on two separate organizations for a fork to be possible.

I realize we can't QA test this with our deployer because you're setting RFC to false in the build script.

Deploys: #77 (comment)

.github/workflows/build.yml

0x4007 · 2024-09-25T22:08:15Z

QA Test Results

Context

I merged the "backend" changes (to sync every issue basically) and now work.ubq.fi currently displays everything, even if they don't have prices.

Requested Changes

This makes me think: the environment variable approach seems wrong.
Why don't you just add a checkbox toggle/filter "Tasks" and when clicked it switches to "Proposals" or something?
This is intended to hide all the issues without a Price label.

"Backend" Delta Summary

58 open ➡️ 143 open...

Run npx tsx ./scripts/delete-unauthorized-issues.ts
  
Deleting issue https://github.com/ubiquity/devpool-directory/issues/1[10](https://github.com/ubiquity/devpool-directory/actions/runs/11041825775/job/30672939774#step:8:10)9 created by bot ubiquibot[bot]
Deleting issue https://github.com/ubiquity/devpool-directory/issues/817 created by bot ubiquibot[bot]
Deleting issue https://github.com/ubiquity/devpool-directory/issues/816 created by bot ubiquibot[bot]
Deleting issue https://github.com/ubiquity/devpool-directory/issues/815 created by bot ubiquibot[bot]
Deleting issue https://github.com/ubiquity/devpool-directory/issues/741 created by bot ubiquibot[bot]
Deleting issue https://github.com/ubiquity/devpool-directory/issues/589 created by bot ubiquibot[bot]

137 open net result.

Screenshot

It looks like it works as expected with RFC env var! How did you test/develop this? Perhaps you could have shown us screenshots and proof on your end? Apologies for the slow review period but that certainly would have sped things along!

Remarks

Archived Repositories

Just realized we have another task open for it so we can let it slide for this pull Close issues from archived repositories devpool-directory-tasks#32
Example: NFT sale strategy launch-party#4

xno-miner added 2 commits August 15, 2024 17:42

only display tasks with price labels

2bc38ac

use request pagination

2801c52

xno-miner mentioned this pull request Aug 15, 2024

Add support for proposals on work.ubq.fi ubiquity/.github#115

Closed

xno-miner added 2 commits August 15, 2024 19:47

my supabase

2cfd8f3

revert

1fff162

0x4007 reviewed Aug 15, 2024

View reviewed changes

package.json Outdated Show resolved Hide resolved

0x4007 reviewed Aug 15, 2024

View reviewed changes

src/home/fetch-github/fetch-issues-preview.ts Outdated Show resolved Hide resolved

xno-miner and others added 4 commits August 17, 2024 20:57

Add RFC env var

a5cb82b

Remove the thing in package.json

d1a316d

Co-authored-by: アレクサンダー.eth <4975670+0x4007@users.noreply.github.com>

use octokit pagination

0a25f54

use octokit pagination

1f2bd94

xno-miner changed the title ~~Only display tasks with price labels~~ Only display tasks with price labels (or without, depending on env) Aug 17, 2024

xno-miner and others added 3 commits August 20, 2024 00:06

fix: restore removed line

c3f4526

fix: change false to "false" in cypress-testing.yml

adb0a3c

fix: cypress test does not attempt to scroll right on mobile

f14181a

fix: don't show price sorting button when RFC is true

334442e

xno-miner marked this pull request as ready for review August 26, 2024 22:04

xno-miner requested a review from 0x4007 August 26, 2024 22:06

0x4007 removed their request for review August 27, 2024 02:39

rndquu self-requested a review August 27, 2024 15:18

rndquu requested changes Aug 27, 2024

View reviewed changes

Merge branch 'development' into development

d296a84

Add default value for RFC

f27d1d7

0x4007 reviewed Sep 25, 2024

View reviewed changes

.env.example Outdated Show resolved Hide resolved

chore: bump ci/cd

6687fef

0x4007 reviewed Sep 25, 2024

View reviewed changes

.github/workflows/build.yml Outdated Show resolved Hide resolved

chore: test build with RFC

f360e4a

0x4007 mentioned this pull request Sep 25, 2024

Sync issues with and without price tags ubiquity/devpool-directory#1250

Merged

0x4007 closed this Sep 26, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Only display tasks with price labels (or without, depending on env) #77

Only display tasks with price labels (or without, depending on env) #77

xno-miner commented Aug 15, 2024

xno-miner commented Aug 15, 2024

ubiquity-os-deployer bot commented Aug 15, 2024 •

edited

Loading

xno-miner commented Aug 17, 2024

rndquu commented Aug 19, 2024

xno-miner commented Aug 19, 2024

xno-miner commented Aug 19, 2024

0x4007 commented Aug 27, 2024 •

edited

Loading

rndquu left a comment

rndquu Aug 27, 2024

xno-miner Aug 28, 2024

rndquu Aug 27, 2024

xno-miner Aug 28, 2024

xno-miner commented Aug 28, 2024

xno-miner commented Aug 28, 2024

xno-miner commented Sep 22, 2024

0x4007 commented Sep 25, 2024 •

edited

Loading

0x4007 commented Sep 25, 2024 •

edited

Loading

Only display tasks with price labels (or without, depending on env) #77

Only display tasks with price labels (or without, depending on env) #77

Conversation

xno-miner commented Aug 15, 2024

xno-miner commented Aug 15, 2024

ubiquity-os-deployer bot commented Aug 15, 2024 • edited Loading

xno-miner commented Aug 17, 2024

rndquu commented Aug 19, 2024

xno-miner commented Aug 19, 2024

xno-miner commented Aug 19, 2024

0x4007 commented Aug 27, 2024 • edited Loading

rndquu left a comment

Choose a reason for hiding this comment

rndquu Aug 27, 2024

Choose a reason for hiding this comment

xno-miner Aug 28, 2024

Choose a reason for hiding this comment

rndquu Aug 27, 2024

Choose a reason for hiding this comment

xno-miner Aug 28, 2024

Choose a reason for hiding this comment

xno-miner commented Aug 28, 2024

xno-miner commented Aug 28, 2024

xno-miner commented Sep 22, 2024

0x4007 commented Sep 25, 2024 • edited Loading

0x4007 commented Sep 25, 2024 • edited Loading

QA Test Results

Context

Requested Changes

"Backend" Delta Summary

Screenshot

Remarks

Archived Repositories

ubiquity-os-deployer bot commented Aug 15, 2024 •

edited

Loading

0x4007 commented Aug 27, 2024 •

edited

Loading

0x4007 commented Sep 25, 2024 •

edited

Loading

0x4007 commented Sep 25, 2024 •

edited

Loading