Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Anschutz Work to Schema YAML #660

Merged
merged 42 commits into from
Mar 14, 2022
Merged

Conversation

prdanelli
Copy link
Contributor

@prdanelli prdanelli commented Feb 18, 2022

Convert the AnshutzWork type to use the Schema YAML. This migration was a little more complicated because of changes to the DOI elsewhere, that had a number of knock on effects here. For other migrations, the process should be much simpler than this PR would have you think.

This PR is ready to be merged and tested in a production environment.

mankind
mankind previously approved these changes Feb 28, 2022
Copy link
Contributor

@mankind mankind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

thenapking
thenapking previously approved these changes Feb 28, 2022
Copy link
Contributor

@thenapking thenapking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This will be a great when it is applied to the other work types.

@prdanelli prdanelli dismissed stale reviews from thenapking and mankind via 264ea74 March 1, 2022 13:08
@prdanelli prdanelli merged commit d236c55 into main Mar 14, 2022
@prdanelli prdanelli deleted the Feature/MigrateAnschutzSchema branch March 14, 2022 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants