Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the instanciation method to be compatible with the native node class #38

Merged
merged 2 commits into from
Jan 9, 2017
Merged

Change the instanciation method to be compatible with the native node class #38

merged 2 commits into from
Jan 9, 2017

Conversation

armandabric
Copy link
Member

@armandabric armandabric commented Jan 9, 2017 •
edited
Loading

This PR solve this issue:

 TypeError: Class constructor HttpClient cannot be invoked without 'new'
         at Object.createInstance (/home/node/node_modules/skippy/src/ObjectHelper.js:25:17)
         at ServiceDefinition.createInstance (/home/node/node_modules/skippy/src/ServiceDefinition.js:47:25)
         at Container.getService (/home/node/node_modules/skippy/src/Container.js:64:45)
         at Container.getService (/home/node/app/src/Bootstrap/Container.js:32:28)
         at /home/node/app/src/Testing/IntegrationTestWorld.js:50:79
         at undefined.next (native)
         at step (/home/node/app/src/Testing/IntegrationTestWorld.js:37:191)
         at /home/node/app/src/Testing/IntegrationTestWorld.js:37:437
         at /home/node/app/src/Testing/IntegrationTestWorld.js:37:99

When will convert this project in ES6 this will be more easy to read.

@armandabric armandabric self-assigned this Jan 9, 2017
@armandabric armandabric added the bug label Jan 9, 2017
@coveralls
Copy link

coveralls commented Jan 9, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.009%) to 98.68% when pulling 330575e on Spy-Seth:fix/native-node-class-compatibility into ce32dfa on rezzza:master.

@armandabric armandabric requested a review from shouze January 9, 2017 10:47
@armandabric armandabric force-pushed the fix/native-node-class-compatibility branch from 330575e to 3f75587 Compare January 9, 2017 10:49
@coveralls
Copy link

coveralls commented Jan 9, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.009%) to 98.68% when pulling 3f75587 on Spy-Seth:fix/native-node-class-compatibility into ce32dfa on rezzza:master.

@armandabric armandabric merged commit 45db015 into ubirak:master Jan 9, 2017
@armandabric armandabric deleted the fix/native-node-class-compatibility branch January 9, 2017 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shouze shouze Awaiting requested review from shouze

Assignees

@armandabric armandabric

Labels
bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@armandabric @coveralls