Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle 415 Http code through custom _supportedFormats attributes #21

Merged
merged 2 commits into from
Sep 4, 2017

Conversation

tyx
Copy link
Member

@tyx tyx commented Sep 4, 2017

No description provided.

tyx added 2 commits September 4, 2017 14:36
When request format violate router supported formats
@tyx tyx self-assigned this Sep 4, 2017
@tyx tyx requested a review from shouze September 4, 2017 12:38
private function requestFormatViolateSupportedFormats($format, $supportedFormats)
{
return null !== $format
&& false !== $supportedFormats
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you mean false !== is_array($supportedFormats)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nop, false is the default value I set when keys is missing

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed 👍

@shouze shouze merged commit da2600d into ubirak:master Sep 4, 2017
@tyx tyx deleted the feature/handle-415-http branch September 4, 2017 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants