Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace int IDs by long ones + a few more changes #811

Merged
merged 5 commits into from
Dec 16, 2024
Merged

Replace int IDs by long ones + a few more changes #811

merged 5 commits into from
Dec 16, 2024

Conversation

louis-z
Copy link
Member

@louis-z louis-z commented Dec 13, 2024 •
edited
Loading

  • Convert int IDs to long
  • As this introduces breaking API changes, take the opportunity to
    • Remove some deprecated code
    • Fix ProjectCreate.NamespaceId's type

Fixes #491, #797

@louis-z louis-z force-pushed the replace-int-ids-by-long-ones branch 2 times, most recently from e601e46 to 3deb559 Compare December 15, 2024 18:21
@louis-z louis-z changed the title Replace int IDs by long ones Replace int IDs by long ones + a few more changes Dec 15, 2024
@louis-z louis-z force-pushed the replace-int-ids-by-long-ones branch from 3deb559 to 7bfaddc Compare December 16, 2024 12:42
@louis-z louis-z marked this pull request as ready for review December 16, 2024 13:05
@louis-z louis-z requested a review from a team as a code owner December 16, 2024 13:05
@louis-z louis-z requested review from Toa741 and removed request for a team December 16, 2024 13:05
@louis-z louis-z marked this pull request as draft December 16, 2024 13:10
@louis-z louis-z marked this pull request as ready for review December 16, 2024 13:54
Toa741
Toa741 reviewed Dec 16, 2024
View reviewed changes
NGitLab.Mock/Project.cs Outdated Show resolved Hide resolved
@Toa741 Toa741 merged commit 8bf473e into main Dec 16, 2024
10 checks passed
@Toa741 Toa741 deleted the replace-int-ids-by-long-ones branch December 16, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Toa741 Toa741 Toa741 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ID needs to change to long or string
2 participants
@louis-z @Toa741