Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert public fields to properties #814

Merged
merged 5 commits into from
Dec 16, 2024
Merged

Convert public fields to properties #814

merged 5 commits into from
Dec 16, 2024

Conversation

louis-z
Copy link
Member

@louis-z louis-z commented Dec 16, 2024 •
edited
Loading

Plus,

  • Make Runner.Online a nullable bool
  • Run dotnet format

Fixes #815, fixes #816

@louis-z louis-z marked this pull request as ready for review December 16, 2024 16:22
@louis-z louis-z requested a review from a team as a code owner December 16, 2024 16:22
@louis-z louis-z requested review from Toa741 and removed request for a team December 16, 2024 16:22
@Toa741 Toa741 merged commit 69e81d3 into main Dec 16, 2024
10 checks passed
@Toa741 Toa741 deleted the convert-public-fields-to-properties branch December 16, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Toa741 Toa741 Awaiting requested review from Toa741 Toa741 is a code owner automatically assigned from ubisoft/ngitlab-owners

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Runners->Online should have been nullable Convert all public fields to properties
2 participants
@louis-z @Toa741