Skip to content

Commit

Permalink
build: fix glslang detection with shared build only
Browse files Browse the repository at this point in the history
A glslang built with dynamic only does not provide any static lib. It is
important to note though that shared builds are not officially supported
by glslang so using them is generally asking for trouble.

See KhronosGroup/glslang#2283
  • Loading branch information
ubitux committed Apr 6, 2023
1 parent bd181eb commit e3ec64b
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions libnopegl/meson.build
Original file line number Diff line number Diff line change
Expand Up @@ -475,9 +475,9 @@ foreach gbackend_name, gbackend_cfg : gbackends_cfg
# linked to SPIRV-Tools:
# - on Linux, it is generally distributed as shared libraries, more
# specifically, libglslang.so, libHLSL.so, libSPVRemapper.so and
# libSPIRV.so are installed. libOGLCompiler.a and libOSDependent.a are
# also provided but not required by the shared libraries. There is no
# dependency between the shared libraries.
# libSPIRV.so are installed. libOGLCompiler.a and libOSDependent.a may
# also be provided but are not required by the shared libraries. There
# is no dependency between the shared libraries.
# - on the other platforms (macOS, Windows, Android, iOS) it is generally
# distributed or installed as static libraries, more specifically,
# libglslang.a, libMachineIndependent.a, libOSDependent.a, libHLSL.a,
Expand All @@ -492,9 +492,9 @@ foreach gbackend_name, gbackend_cfg : gbackends_cfg
{'name': 'glslang', 'required': true},
{'name': 'glslang-default-resource-limits', 'required': true},
{'name': 'MachineIndependent', 'required': false},
{'name': 'OSDependent', 'required': true},
{'name': 'OSDependent', 'required': false},
{'name': 'HLSL', 'required': true},
{'name': 'OGLCompiler', 'required': true},
{'name': 'OGLCompiler', 'required': false},
{'name': 'GenericCodeGen', 'required': false},
{'name': 'SPVRemapper', 'required': true},
{'name': 'SPIRV', 'required': true},
Expand Down

0 comments on commit e3ec64b

Please sign in to comment.