Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Rok CDEmu for including vhba kmod #165

Merged
merged 16 commits into from
Apr 23, 2024
Merged

Conversation

RodoMa92
Copy link
Contributor

@RodoMa92 RodoMa92 commented Apr 7, 2024

No description provided.

@RodoMa92 RodoMa92 requested a review from castrojo as a code owner April 7, 2024 14:10
@RodoMa92 RodoMa92 changed the title Adding Rok CDEmu for adding vhba kmod module feat: add Rok CDEmu for adding vhba kmod module Apr 7, 2024
@RodoMa92 RodoMa92 changed the title feat: add Rok CDEmu for adding vhba kmod module feat: add Rok CDEmu for including vhba kmod Apr 7, 2024
@bsherman
Copy link
Contributor

bsherman commented Apr 7, 2024

@RodoMa92 Hello and thanks for the PR.

I'm not familiar with any history regarding a request to add this kmod to ublue. Was there a Discord discussion to which you can direct me? I don't see an issue requesting it.

Thank you.

@RodoMa92
Copy link
Contributor Author

RodoMa92 commented Apr 8, 2024

@RodoMa92 Hello and thanks for the PR.

I'm not familiar with any history regarding a request to add this kmod to ublue. Was there a Discord discussion to which you can direct me? I don't see an issue requesting it.

Thank you.

If you search for cdemu in the bazzite discord channel there is some hits regarding people who tried to ask for guidance on installing this program. This kmod is a prerequisite to make it work.

I've also opened an issue on the bazzite repo requesting to being included in, if you want more info on what it can do. The issue is this: ublue-os/bazzite#919

@bsherman
Copy link
Contributor

bsherman commented Apr 8, 2024

If you search for cdemu in the bazzite discord channel there is some hits regarding people who tried to ask for guidance on installing this program. This kmod is a prerequisite to make it work.

I've also opened an issue on the bazzite repo requesting to being included in, if you want more info on what it can do. The issue is this: ublue-os/bazzite#919

Perfect! Thank you for the link to the issue and the bigger context.

@KyleGospo
Copy link
Member

@RodoMa92 Went to approve this, but running into:
error: Packages not found: akmod-vhba-*.fc40.x86_64

@KyleGospo
Copy link
Member

@RodoMa92 Fixed that, just need to fix build errors in 38, may just make it not build against 38.

@bsherman
Copy link
Contributor

Approved and direct merged. Will do full rebuild later.

@bsherman bsherman merged commit fedcad9 into ublue-os:main Apr 23, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants