Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Install CDEmu daemon and client plus GUI apps #956

Closed
wants to merge 6 commits into from
Closed

feat: Install CDEmu daemon and client plus GUI apps #956

wants to merge 6 commits into from

Conversation

RodoMa92
Copy link
Contributor

@RodoMa92 RodoMa92 commented Apr 7, 2024

This depends on ublue-os/akmods#165 before being functional.

I'll mark this as a draft since I still need to create a package for https://github.com/marcelh83/kde-cdemu-manager as a GUI client alternative for KDE and then install it onto the KDE flavour image, even if you still can manually mount it from the CLI just fine as is.

This is already in, it should be ready to test.

This will fix #919.

@RodoMa92 RodoMa92 marked this pull request as ready for review April 8, 2024 18:31
@RodoMa92 RodoMa92 requested a review from EyeCantCU as a code owner April 8, 2024 18:31
@KyleGospo
Copy link
Member

Hey I know I'm slow to review this right now, I'm going to try and make this part of the Fedora 40 launch so expect it to get reviewed and tested here soon.

@RodoMa92
Copy link
Contributor Author

Hey I know I'm slow to review this right now, I'm going to try and make this part of the Fedora 40 launch so expect it to get reviewed and tested here soon.

No problem @KyleGospo, take the time you need :)

@KyleGospo
Copy link
Member

KyleGospo commented Apr 23, 2024

@RodoMa92 kmod is merged for F40. As for this PR, I'd like to change it to make the various apps an optional layer via ujust, similarly to how we do sunshine.

@RodoMa92
Copy link
Contributor Author

Yeah, sure. For KDE 6 (and fedora 40) the package for kde is different, it has the suffix kf6 (since it had recently been ported to it). That's still missing in here.

@KyleGospo
Copy link
Member

@RodoMa92 Since we're merging for F40 you can just check for silverblue/kinoite and assume KDE6

@KyleGospo
Copy link
Member

KyleGospo commented Apr 23, 2024

Also means this PR can be moved against :testing and then I can immediately merge it when ready.

@RodoMa92
Copy link
Contributor Author

Everything should be ready to test, @KyleGospo :)

@KyleGospo
Copy link
Member

See 3c38bd3

@KyleGospo KyleGospo closed this Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding CDEmu for easier CD image mounting experience for old games
2 participants