feat: Adding Framework power kmod #139
Conversation
| ARCH="$(rpm -E '%_arch')" | ||
| KERNEL="$(rpm -q "${KERNEL_NAME}" --queryformat '%{VERSION}-%{RELEASE}.%{ARCH}')" | ||
| RELEASE="$(rpm -E '%fedora')" | ||
|
|
There was a problem hiding this comment.
I think you should take a look at build-kmod-v4l2loopback.sh and add a similar conditional to this script so that it only runs on main KERNEL_FLAVOR and RELEASE >= 39.
You'll need to move the cp for the COPR repo after the conditional as well.
There was a problem hiding this comment.
Ok, so the kernel flavor is just nvidia or main right now yea? Given that frameworks don't have nvidia drivers that's safe to exit as well. So I think the != main is still fine. I've got a commit that will do that, but now that I've taken a look at it, I don't think that this is my only concern. Its very likely "a" concern, but there are other things that are still borked I think.
There was a problem hiding this comment.
Kernel flavors can be found here: https://github.com/ublue-os/akmods/blob/main/.github/workflows/reusable-build.yml#L30-L34
There was a problem hiding this comment.
Fantastic, given that my != main should still stand.
|
F40 fails with: Looks like it's not here: https://copr.fedorainfracloud.org/coprs/ublue-os/akmods/packages/ Is that where you expected to find the akmod RPM? |
Per this issue: #137 I am attempting to add https://github.com/DHowett/framework-laptop-kmod as a mod, I believe I've wrapped it in a COPR properly? But have no way of testing it in ublue if its not in this repository. I am definitely very new at this kind of work so any feedback is appreciated. For the record, my COPR is here: https://copr.fedorainfracloud.org/coprs/waffleophagus/framework-laptop-tests/packages/