chore: Switch from dconf to gschema-overrides #1716
Conversation
I removed `gdm` profile because it's already present in `/usr/share/dconf/profile`. I removed touchpad tap-to-click setting, because it's already the default since Gnome 46 (next GTS will be on Gnome 46). I removed `user` profile because it's already present in `/etc/dconf/profile/`. I moved dconfs from `local.d` to `distro.d`, as that's recommended to do as a distribution/custom image maintainer. `local.d` is intended for local-users, so let's make that easier for them. Relocatable schemas & locked settings are not supported in gschema-overrides, hence why they remained in dconf. I commented the gschema override, to make it easier to see where relocatable schemas are located. `gsettings list-relocatable-schemas` can be used to check those. We use `zz0-` prefix for gschema override, so that we can assure that Fedora gschema-override defaults won't override Bluefins. Downstreams can use `zz1-`, `zz2-`, `zz3-`, etc. prefix, like I recommend BlueBuild users to do so. Gschema overrides can be checked in build-time for errors in case some keys get migrated or someone makes an unintentional typing mistake, where dconf ones can't. So let's utilize that to our advantage. Bluefin should work without problems, but I'll have to additionally test Aurora, to see how Ptyxis dconfs are handled there.
dosubot
bot
added
the
size:L
|
Tested Aurora, it works great |
Those 2 extensions miss gschema xml, hence the reason why gschema overrides doesn't work for them. This is fixable, but not by me.
|
Tested & fixed remaining Bluefin settings, everything works! This is ready to merge |
What happens to existing gts users if this merges right now? |
They'll have this setting off by default Unless the user manually toggled off, then on that setting, which is very unlikely |
|
Ok what about leaving it in for now but leaving a comment like |
No problem, I'll add it back |
|
Added |
|
Great idea, I merged that PR, ready to go! |
|
@castrojo Ready! |
- See ublue-os/bluefin#1716 - Rename our gschema overrides to match convention
What I did
I removed
gdmprofile because it's already present in/usr/share/dconf/profile/.I removed touchpad tap-to-click setting, because it's already the default since Gnome 46 (next GTS will be on Gnome 46).
I removed
userprofile because it's already present in/etc/dconf/profile/.I moved dconfs from
local.dtodistro.d, as that's recommended to do as a distribution/custom image maintainer.local.dis intended for local-users, so let's make that easier for them.Relocatable schemas & locked settings are not supported in gschema-overrides, hence why they remained in dconf.
I commented the gschema override, to make it easier to see where relocatable schemas are located.
gsettings list-relocatable-schemascan be used to check those on booted system.We use
zz0-prefix for gschema override, so that we can assure that Fedora gschema-override defaults won't override Bluefins. Downstreams can usezz1-,zz2-,zz3-, etc. prefix, like I recommend BlueBuild users to do so.Gschema overrides can be checked in build-time for errors in case some keys get migrated or someone makes an unintentional typing mistake, where dconf ones can't. So let's utilize that to our advantage.
Testing
Bluefin should work without problems, but I'll have to additionally test Aurora, to see how Ptyxis dconfs are handled there.