Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ptyxis): remove profile integration ootb #1948

Merged
merged 3 commits into from
Nov 23, 2024

Conversation

tulilirockz
Copy link
Collaborator

This PR is based off of #1901, should look prettier after it gets merged. (this will also get edited out whenever that happens)

We just need to figure out if we should have a default profile so that we can apply theming to it. Aurora customizes it to have the Breeze look so that it looks a bit more cohesive with the system, but to be completely honestly, none of these profile things worked properly on my system ever, soo......

Copy link
Member

@m2Giles m2Giles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good for removing everything.

Ptyxis in Aurora sets pallette and opacity via a dconf file. This probably could be moved to a skel file or added to the gschema xml but is inconsequential right now.

@tulilirockz tulilirockz force-pushed the remove-ptyxis-manipulation branch from 4763429 to edb10f2 Compare November 22, 2024 15:50
@tulilirockz tulilirockz marked this pull request as ready for review November 22, 2024 21:25
@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Nov 22, 2024
castrojo
castrojo previously approved these changes Nov 23, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 23, 2024
@castrojo castrojo added this pull request to the merge queue Nov 23, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Nov 23, 2024
@tulilirockz tulilirockz force-pushed the remove-ptyxis-manipulation branch from edb10f2 to 9422d6f Compare November 23, 2024 04:06
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Nov 23, 2024
@tulilirockz tulilirockz force-pushed the remove-ptyxis-manipulation branch from 9422d6f to 74cd94e Compare November 23, 2024 04:07
@castrojo castrojo enabled auto-merge November 23, 2024 04:09
@castrojo castrojo added this pull request to the merge queue Nov 23, 2024
Merged via the queue into ublue-os:main with commit 4ea2f4d Nov 23, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants