feat: add devcontainer #2131
Merged
feat: add devcontainer #2131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in docker, images are tagged to docker.io by default, this makes the behaviour consistent with podman, where localhost is used instead
fallback to 'missing' since podman's 'newer' is not available in docker
tested working recipes in devcontainer: * just build * just run * just build-iso * just run-iso
dosubot
bot
added
size:M
|
Also need to check rechunk. But it should work with docker out of docker. Did you try Docker in Docker? I think this one is probably a footgun with people trying to do this inside of a rootless podman container though. |
Docker in docker throws a bunch of permissions errors, I didn't dig too deep though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2046
I've confirmed that the following recipes are working properly inside the devcontainer: