Use usermod instead of lchsh in custom.just
#585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes #408 (`just fish` and `just zsh` failing). The problem (and the reason that #420 doesn't fix it) is because the `lchsh` command actually doesn't accept the new shell as a CLI argument at all! Another way to do this (and continue using `lchsh`) would be to instead run the commands as, e.g., `echo /usr/bin/zsh | sudo lchsh $USER`, but this results in an empty (and thus slightly misleading) prompt being shown to the user: ```console $ echo /usr/bin/zsh | sudo lchsh $USER [sudo] password for bri: Changing shell for bri. New Shell [/usr/bin/zsh]: Shell changed.``` If we just use `usermod` it doesn't actually give any feedback, so I also threw in a little posix pipe to parse the shell back out of /etc/passwd after.
This fixes #408 (`just fish` and `just zsh` failing). The problem (and the reason that #420 doesn't fix it) is because the `lchsh` command actually doesn't accept the new shell as a CLI argument at all! Another way to do this (and continue using `lchsh`) would be to instead run the commands as, e.g., `echo /usr/bin/zsh | sudo lchsh $USER`, but this results in an empty (and thus slightly misleading) prompt being shown to the user: ```console $ echo /usr/bin/zsh | sudo lchsh $USER [sudo] password for bri: Changing shell for bri. New Shell [/usr/bin/zsh]: Shell changed. ``` If we just use `usermod` it doesn't actually give any feedback, so I also threw in a little posix pipe to parse the shell back out of /etc/passwd after.
castrojo
approved these changes
Oct 13, 2023
There was a problem hiding this comment.
This is awesome, thank you! I'm sure @bketelsen will be happy!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #408 (
just fishandjust zshfailing). The problem (and the reason that #420 doesn't fix it) is because thelchshcommand actually doesn't accept the new shell as a CLI argument at all!Another way to do this (and continue using
lchsh) would be to instead run the commands as, e.g.,echo /usr/bin/zsh | sudo lchsh $USER, but this results in an empty (and thus slightly misleading) prompt being shown to the user:If we just use
usermodit doesn't actually give any feedback, so I also threw in a little posix pipe to parse the shell back out of /etc/passwd after.