chore: move to charm.sh repo #664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was just thinking, we want this on the base bluefin image probably and not only in bluefin-dx because we will use them in just commands? If that is correct I need to fix this before merging. We talked about this in the PR when gum entered bluefin-dx For example this "blinged" up command would only work on bluefin-dx |
|
I've moved them to the |
castrojo
approved these changes
Nov 17, 2023
b-
pushed a commit
to briorg/bluefin
that referenced
this pull request
Dec 9, 2023
awesomekyle
pushed a commit
to awesomekyle/bluefin
that referenced
this pull request
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #661
In the issue was spoken about re-addings VHS. That is not done in this PR. I would like to suggest to add VHS as part of the fleekbrew configuration.
The reasons for this is that even it is as simple as add vhs to the packages.json, it still needs a ttyd dep that we need to ship via the container. I think that would be nice to handle all via the fleekbrew.