fix(just): correct the arg order for AssembleList when making mlbox #845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
castrojo
approved these changes
Jan 28, 2024
m2Giles
approved these changes
Jan 28, 2024
wizzywizard65
pushed a commit
to wizzywizard65/bluefin
that referenced
this pull request
Jan 29, 2024
* feat: Switch to much smaller nerd-fonts package (ublue-os#837) * feat: Switch to topgrade powered ublue-update (ublue-os#835) * feat(ci): Introduce a testing tag (ublue-os#838) * feat: Add default config for Pods flatpak (ublue-os#839) * fix: Correct skel.d error in installer * feat: add user-motd banner (ublue-os#840) * chore: doens't -> doesn't (ublue-os#841) * feat: Initial Container wireup (ublue-os#844) * fix(just): correct the arg order for AssembleList when making mlbox (ublue-os#845) * fix: quadlet locations (ublue-os#846) * feat: Add dynamic MOTD tips and image info (ublue-os#847) * fix: Correct motd syntax * fix: Correct skel path for dx files * fix: small adjustments to motd (ublue-os#848) Co-authored-by: Kyle Gospodnetich <me@kylegospodneti.ch> * feat: jazz up the motd (ublue-os#849) * fix: Add nerd fonts to all images * chore: Remove nerd font repo once it's no longer needed * fix(motd): minor text fix (ublue-os#851) * fix: add more tips * fix: update motd generation (ublue-os#853) Co-authored-by: Kyle Gospodnetich <me@kylegospodneti.ch> * feat(just): remove things we don't use from the justfile (ublue-os#852) --------- Co-authored-by: Kyle Gospodnetich <me@kylegospodneti.ch> Co-authored-by: RJ Trujillo <rjtrujillo@protonmail.ch> Co-authored-by: Benjamin Sherman <benjamin@holyarmy.org> Co-authored-by: Justin Plock <jplock@users.noreply.github.com> Co-authored-by: m2Giles <69128853+m2Giles@users.noreply.github.com> Co-authored-by: HikariKnight <2557889+HikariKnight@users.noreply.github.com> Co-authored-by: Jorge O. Castro <jorge.castro@gmail.com>
awesomekyle
pushed a commit
to awesomekyle/bluefin
that referenced
this pull request
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recipe for mlbox accidentally used the Assemble argument order (action, file, container/name) similar to the
distrobox assemblecommand, instead of the AssembleList order (file, action, name) which is "Assemble a list fromfilewe want toactionfrom andnamejust just a quick selection"This fixes #842