Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Default icons on the local audio list page are not displayed completely #829

Merged

Conversation

dongfengweixiao
Copy link
Contributor

Change the size value of the default icon from the original fixed value of 70 to 70% of the height to resolve the issue of incomplete display of the default icon.
before:
Snipaste_2024-08-06_22-53-54
after:
Snipaste_2024-08-06_22-55-16

Copy link
Member

@Feichtmeier Feichtmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Height can be null so you need to use the ? operator instead

…pletely.

Change the size value of the default icon from the original fixed value of 70 to 70% of the height to resolve the issue of incomplete display of the default icon.
@dongfengweixiao
Copy link
Contributor Author

Height can be null so you need to use the ? operator instead

size: height != null ? height! * 0.7 : null,

when size not set:
Snipaste_2024-08-07_09-33-48

The displayed icon will be smaller than the size value set, but it can be fully displayed.

@Feichtmeier Feichtmeier enabled auto-merge (squash) August 7, 2024 05:23
@Feichtmeier Feichtmeier merged commit 6000d6a into ubuntu-flutter-community:main Aug 7, 2024
4 checks passed
@dongfengweixiao dongfengweixiao deleted the fix/iconSize branch August 7, 2024 09:08
@github-actions github-actions bot mentioned this pull request Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants