Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icons to power profile section #301

Merged
merged 1 commit into from
Mar 12, 2022
Merged

Add icons to power profile section #301

merged 1 commit into from
Mar 12, 2022

Conversation

Jupi007
Copy link
Collaborator

@Jupi007 Jupi007 commented Mar 12, 2022

A small PR to add some colored icons to the power profile section :)

Capture d’écran du 2022-03-12 22-00-53

@Jupi007 Jupi007 requested a review from Feichtmeier March 12, 2022 21:03
Copy link
Member

@Feichtmeier Feichtmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, thanks!

@Jupi007
Copy link
Collaborator Author

Jupi007 commented Mar 12, 2022

The CI fail cause to files I didn't edited 🤔
Should I still merge?

@Feichtmeier
Copy link
Member

uhm... where does this come from Oo

warning - lib/view/pages/bluetooth/bluetooth_device_model.dart:88:30 - The '!' will have no effect because the receiver can't be null. Try removing the '!' operator. - unnecessary_non_null_assertion
   info - lib/services/power_settings_service.dart:80:16 - This function has a nullable return type of 'FutureOr<int?>', but ends without returning a value. Try adding a return statement, or if no value is ever returned, try changing the return type to 'void'. - body_might_complete_normally_nullable
   info - lib/services/power_settings_service.dart:87:27 - The exception variable 'e' isn't used, so the 'catch' clause can be removed. Try removing the catch clause. - unused_catch_clause

oh... it was changed in the the displays PR oO

@Feichtmeier
Copy link
Member

Yes merge, I fix it later

@Jupi007 Jupi007 merged commit f8f551e into master Mar 12, 2022
@Jupi007 Jupi007 deleted the Power_profile_icons branch March 12, 2022 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants