Skip to content

Commit

Permalink
Ensure CI can run on forked repo PRs
Browse files Browse the repository at this point in the history
Hardcode the runner in the workflow directly instead of GH project
config as it’s not available to the forked repositories otherwise when
submitting PRs: https://github.com/orgs/community/discussions/44322.
Workflow environment variables are not accessible on runs-on either.
  • Loading branch information
didrocks committed Sep 17, 2024
1 parent bd1e473 commit 730c7b6
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions .github/workflows/qa.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,10 @@ env:
jobs:
sanity:
name: Code sanity
runs-on: ${{ vars.RUNNER }}
# Put the runner here instead of GH project config as it’s not available to the forked repositories
# otherwise when submitting PRs: https://github.com/orgs/community/discussions/44322.
# workflow environements don’t work either.
runs-on: ubuntu-24.04
steps:
- name: Install dependencies
run: |
Expand All @@ -43,7 +46,7 @@ jobs:

tests:
name: Tests
runs-on: ${{ vars.RUNNER }}
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@v4
- uses: actions/setup-go@v5
Expand Down

0 comments on commit 730c7b6

Please sign in to comment.