Add GPO list daemon timeout option #1097
Conversation
|
Everyone contributing to this PR have now signed the CLA. Thanks! |
dangerousplay
force-pushed
the
add-gpo-list-timeout-option
branch
10 times, most recently
from
f9ccaa4
to
0e965aa
Compare
Signed-off-by: Davi Henrique <dangerousplay715@gmail.com>
dangerousplay
force-pushed
the
add-gpo-list-timeout-option
branch
from
0e965aa
to
95676e8
Compare
There was a problem hiding this comment.
Excellent! Thanks for contributing to adsys and help making it better (and work in your case :)). I think the approach makes sense. You are the first one enduring this timeout. We may increase the default later if more cases occurred, but let’s keep it that way with your configuration option to accomodate other scenarios for now.
I have one small nitpick in the example configuration file. We can modify it after merging if you don’t have time to modify it. It’s up to you, just tell us :)
Then, we can merge.
Thanks again for this very valuable contribution!
Signed-off-by: Davi Henrique <dangerousplay715@gmail.com>
|
Thank you, pull request updated with the suggestion ^^ |
Generated documentation should have capitalized GPO for consistency across the doc. However, as gpo is also used as an argument of the config, put it in the allowed list.
didrocks
force-pushed
the
add-gpo-list-timeout-option
branch
from
b857378
to
73212e1
Compare
There was a problem hiding this comment.
Thanks a lot for you work! I just pushed one commit to fix the capitalization of "gpo" in the help, as the generated helper from the reference command line was making the documentation check (so that we don’t have a mix of "GPO" and "gpo" in it). Howver, because of the configuration using "gpo", I had to make it enter the allowed list too. I didn’t want you to have to bother with this :)
Everything looks excellent! Approving and merging, thanks again :)
Hello, I hope you are good.
Added a
--gpo-list-timeoutflag and agpo_list_timeoutconfiguration parameter on the adsys daemon.By default, the GPO list timeout is fixed to 10 seconds. If the GPO list python script takes more than 10 seconds it's killed by the timeout. However, there might be scenarios where 10 seconds might not be enoguth. In our use case, the GPO list procedure finishes around 15 seconds in average.
Have a wonderful day ^^