tests: Handle some failures when using -race #739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's just nicer API for testing
3v1n0
force-pushed
the
some-goraces-handling
branch
from
342d4e1 to
3b403b0
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #739 +/- ##
==========================================
- Coverage 83.43% 83.07% -0.37%
==========================================
Files 83 96 +13
Lines 8689 9585 +896
Branches 74 74
==========================================
+ Hits 7250 7963 +713
- Misses 1111 1238 +127
- Partials 328 384 +56 ☔ View full report in Codecov by Sentry. |
adombeck
reviewed
Jan 20, 2025
adombeck
reviewed
Jan 20, 2025
3v1n0
force-pushed
the
some-goraces-handling
branch
2 times, most recently
from
74f8df0 to
f6d13c8
Compare
Errno may be accessed by other code during the go execution, breaking our assumptions. So let's test that our code is race-free by using a test variable instead.
…vhs output Since the introduction of the VHS wait feature we may get the data race output as VHS error, so let's handle it earlier if vhs process fails. We still keep the check in the golden file, as we may still get a race output after a successful Wait. Closes: ubuntu#703
We were relying on the process output to check on data races, while Go allows us to write the race content
3v1n0
force-pushed
the
some-goraces-handling
branch
from
f6d13c8 to
6c1bf10
Compare
adombeck
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commits for details.
Close: #703
UDENG-5710