debian/authd.service: Use even more restrictive access for authd #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Authd doesn't require network access (the brokers may), but the daemon can safaly live without any network access, we only care about being able to connect to unix sockets!
We're using these paths in authd too, so let's just make it clearer in the service file.
authd should not care about having access to most of system places so let's restrict the process even more.
While we can't use /etc in read-only mode via ProtectSystem=full, because we use gpasswd to write on /etc/groups and /etc/gshadow, we can still limit the access to the most sensible /etc paths.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #740 +/- ##
==========================================
- Coverage 83.43% 83.11% -0.33%
==========================================
Files 83 96 +13
Lines 8689 9588 +899
Branches 74 74
==========================================
+ Hits 7250 7969 +719
- Misses 1111 1236 +125
- Partials 328 383 +55 ☔ View full report in Codecov by Sentry. |
didrocks
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Limit the authd access on system resources even more, to prevent unexpected behaviors.
UDENG-5583