Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow ci reruns and update upload artifact action #239

Merged
merged 3 commits into from
Sep 13, 2024

Conversation

jssotomdz
Copy link
Contributor

No description provided.

@jssotomdz
Copy link
Contributor Author

@sergio-costas @seb128 should I commit the v4 change directly into the rest of the repos? to avoid spamming and creating >20 pull requests

Copy link
Contributor

@sergio-costas sergio-costas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know about the "workflow_dispatch:" entry, but the version change is exactly what it has to be done to fix it.

@sergio-costas
Copy link
Contributor

@jssotomdz In my opinion, yes, you should do that. It's a sensible change.

Copy link
Contributor

@seb128 seb128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know about the "workflow_dispatch:" entry, but the version change is exactly what it has to be done to fix it.

The workflow_dispatch gives you the ability to trigger the job manually

The changes makes sense to me, thanks!

@seb128 seb128 merged commit 7a06171 into ubuntu:gnome-42-2204-sdk Sep 13, 2024
1 check passed
@sergio-costas
Copy link
Contributor

@seb128 Oh, good to know. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants