List shell version 43 in metadata.json #351
Conversation
emansom
changed the title
|
Looks good, but just use |
emansom
force-pushed
the
feature/gnome43
branch
from
d580a47 to
4e37f24
Compare
Done. 👍🏻 Updated this PR to include |
emansom
changed the title
|
So Appindicator is already compatible with Gnome 43? |
|
@litLizard69 Not until this PR is merged and a new release is tagged. |
Ahh, well then looking forward for the merge and release tag! |
|
I'm using it on gnome 43 rc. I get error. |
Well this is because support for Gnome 43 hasn't been merged yet. When Gnome 43 releases it will be there I think |
|
GNOME 43 was released today. |
|
Tested on Gnome 43/Fedora 37. Works fine. 👍 |
|
Regarding Fedora 37, there is this issue that may (or may not) be related to gnome-shell-extension-appindicator. But it was only one person who had this issue so far. |
Instead of adding the icons when they are visible, add them once we create them and just show them when ready. So we can cleanup the code a bit splitting a bit the container vs actor duties. Related-to: #351
…emoval
We used to remove the shell tray icon but not its parent, and this may
have lead to wrong behavior, other than errors on the logs:
(gnome-shell:1330802): Clutter-CRITICAL **: clutter_actor_iter_next:
assertion 'ri->age == ri->root->priv->age' failed
Closes: #351
|
I've rebased it as #364 (it's in the same branch as before though), please test it again so that I can prepare a 43 release. |
Works as expected on GNOME 43.0. 🙂 Showing CLight GUI's tray applet.
For other people on Arch to easily test: updated the AUR package gnome-shell-extension-appindicator43 mentioned in first comment, and submitted a PR to the FCGU repo to reflect the changes as well. |
Works without a hitch in GNOME 43.alpha. No errors nor warnings reported in logs.
AppIndicator menu from CLight GUI shown in screenshot below as example of it working correctly.
Using FCGU repo and AUR package gnome-shell-extension-appindicator43 to test.