DCF PROD RELEASE Q3 1596041133 #1889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nci-crdc.datacommons.io/manifest.jsonDeployment changes
|
nci-crdc.datacommons.io/manifest.jsonDeployment changes
|
emalinowski
reviewed
Jul 29, 2020
| } | ||
| }, | ||
| "sower": [ | ||
| { | ||
| "name": "manifest-indexing", | ||
| "action": "index-object-manifest", | ||
| "activeDeadlineSeconds": 86400, | ||
| "serviceAccountName": "jobs-nci-crdc-datacommons-io", | ||
| "serviceAccountName": "jobs-nci-crdc-staging-datacommons-io", |
There was a problem hiding this comment.
This should not be changed
There was a problem hiding this comment.
wow, nice catch 👏
nci-crdc.datacommons.io/manifest.jsonDeployment changes
|
emalinowski
reviewed
Jul 29, 2020
| @@ -84,10 +84,10 @@ | |||
| "name": "indexd-manifest", | |||
| "action": "download-indexd-manifest", | |||
| "activeDeadlineSeconds": 86400, | |||
| "serviceAccountName": "jobs-nci-crdc-datacommons-io", | |||
| "serviceAccountName": "jobs-nci-crdc-staging-datacommons-io", | |||
There was a problem hiding this comment.
This should not be changed
nci-crdc.datacommons.io/manifest.jsonDeployment changes
|
nci-crdc.datacommons.io/manifest.jsonDeployment changes
|
itsJiaqi
approved these changes
Jul 30, 2020
ADParedes
approved these changes
Jul 30, 2020
emalinowski
approved these changes
Aug 3, 2020
itsJiaqi
deleted the
chore/promote_nci-crdc-staging_datacommons_io_1596041133
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
copying files from nci-crdc-staging.datacommons.io to nci-crdc.datacommons.io