-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IRSA Changes #2531
IRSA Changes #2531
Conversation
Please find the detailed integration test report here Please find the ci env pod logs here |
Please find the detailed integration test report here Please find the ci env pod logs here |
Please find the detailed integration test report here Please find the ci env pod logs here |
Please find the detailed integration test report here Please find the ci env pod logs here |
Please find the detailed integration test report here Please find the ci env pod logs here |
The bullet points in this PR description are not displaying well in the release notes, see here, please read https://github.com/uc-cdis/cdis-wiki/blob/master/dev/release_notes.md for guidance |
Improvements
These are the changes necessary for the "batch-export" sower job to run with IRSA instead of AWS keys. Also, the batch-export job will no longer rely on the config.json file. Instead, it will automatically create a batch-export-g3auto configmap that contains the bucket name. This bucket name will then be passed into the export job as an environment variable.
Deployment changes
Manifest.json files MUST be changed to use the new "batch-export-sa" service account and the "BUCKET" environment variable must be set to the batch-export-g3auto secret with the "bucket_name" key. You also no longer need to mount the batch-export-g3auto secret as this is now deprecated (it is replaced by the batch-export-g3auto configmap).