Chore/update discoverydropdowntag #1123
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <Col > | ||
| <Tooltip | ||
| placement='left' | ||
| overlay={category.tooltip} |
There was a problem hiding this comment.
the tooltip field should be added to the docs at docs/portal_config.md
There was a problem hiding this comment.
I added tooltip": "additional data", // optional string to add data when hovered on the info button at portal_config.md
mfshao
reviewed
Oct 18, 2022
There was a problem hiding this comment.
should also add similar feature into https://github.com/uc-cdis/data-portal/blob/master/src/Discovery/DiscoveryTagViewer.tsx because they are basically the same thing with different appearences
| overlay={category.tooltip} | ||
| overlayClassName='g3-filter-section__and-or-toggle-helper-tooltip' | ||
| arrowContent={<div className='rc-tooltip-arrow-inner' />} | ||
| width='300px' |
| </Tooltip> | ||
| </Col> | ||
| </td> | ||
| <td width='500px' > |
This was referenced Dec 25, 2022
|
closing to cleanup prs if this is still an issue please address above cements and reopen |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added code for tooltip info button right next to each study filter category with additional data in DiscoveryDropdownTagViewer.tsx file under uc-cdis/data-portal/src/Discovery.