Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: adjust CustomDichotomousCovariates storybook to component's interface #1237

Merged
merged 1 commit into from
Feb 21, 2023
Merged

fix: adjust CustomDichotomousCovariates storybook to component's interface #1237

merged 1 commit into from
Feb 21, 2023

Conversation

pieterlukasse
Copy link
Contributor

@pieterlukasse pieterlukasse commented Feb 17, 2023 •
edited
Loading

Jira Ticket: VADC-414

Bug Fixes

Improvements

  • Removed unnecessary .css import in ContinuousCovariates.stories.jsx
  • Added extra storybook scenario for CustomDichotomousCovariates to allow for checking the behaviour of the component when a zero overlap selection occurs.

@pieterlukasse pieterlukasse changed the base branch from master to feat/vadc_sprint04 February 21, 2023 14:46
jarvisraymond-uchicago
jarvisraymond-uchicago approved these changes Feb 21, 2023
View reviewed changes
Copy link
Contributor

@jarvisraymond-uchicago jarvisraymond-uchicago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to successfully create a no overlap visualization:

image

I'm seeing styling differences between the storybook and the web app. Let me know your thoughts on creating a ticket to align the storybooks back up with the web app.

@pieterlukasse
Copy link
Contributor Author

pieterlukasse commented Feb 21, 2023 •
edited
Loading

Let me know your thoughts on creating a ticket to align the storybooks back up with the web app.

I agree w/ having a different ticket to align styling of storybook and the app 👍

@pieterlukasse pieterlukasse merged commit 06215fb into feat/vadc_sprint04 Feb 21, 2023
@pieterlukasse pieterlukasse deleted the fix/storybook_custom_dichotomous_covariates branch February 21, 2023 16:37
@jarvisraymond-uchicago
Copy link
Contributor

Let me know your thoughts on creating a ticket to align the storybooks back up with the web app.

I agree w/ having a different ticket to align styling of storybook and the app 👍
Created ticket here:
https://ctds-planx.atlassian.net/browse/VADC-451

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarvisraymond-uchicago jarvisraymond-uchicago jarvisraymond-uchicago approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pieterlukasse @jarvisraymond-uchicago