Feat/vadc sprint04 #1246
Merged
Feat/vadc sprint04 #1246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat(eulerDiagramLegend): Initial commit * feat(eulerDiagramLegend):Working prototype * feat(eulerDiagramLegend): Adjusted diagram size to avoid overflowing and resolved eslint errors * feat(eulerDiagramLegend): Resolved stylelint errors * feat(eulerDiagramLegend): Removed unneeded comments from simple3setseulerdiagram.jsx * feat(eulerDiagramLegend): Adjusted heights so buttons do not shift between diagram and text version * feat(eulerDiagramLegend): Removed unneeded D3 style function * feat(eulerDiagramLegend): Ran autoformatters * feat(eulerDiagramLegend): Formatted CSS to match rest of codebase * feat(eulerDiagramLegend): Wrote test for CohortsOverlapTextVersion * feat(eulerDiagramLegend): Wrote test for CohortsOverlapLegend.test * feat(eulerDiagramLegend): Fixed error in test for CohortsOverlapLegend * feat(eulerDiagramLegend): Removed unneeded line breaks from CohortsOverlapLegend * feat(eulerDiagramLegend): Ran Eslint new which updated CohortsOverlapLegend.text.jsx * feat(eulerDiagramLegend): Swapped buttons position, changed file name, added title as component prop for text version * feat(eulerDiagramLegend): Added missing prop type * feat(eulerDiagramLegend): Added logic to JSX to toggle button type for text version controls * feat(eulerDiagramLegend): Ran linter * feat(eulerDiagramLegend): Fixed component name issue in Simple3SetsOverlapTextVersion
* feat(VADC-431): add uid to argo-wrapper requests * chore(VADC-431): update storybook tests to include uid * fix: better logging for GWASWorkflowList storybook --------- Co-authored-by: pieterlukasse <pieterlukasse@gmail.com>
* feat(gwasV2Cleanup): Made it to line 268 in GWASUIApp.css * feat(gwasV2Cleanup): Finished grepping for unused styles from GWASUIApp.css * feat(gwasV2Cleanup): Renamed GWASUIApp.css to GWASResults.css and updated references to it * feat(gwasV2Cleanup): Renamed GWASV2 to GWASApp * feat(gwasV2Cleanup): Fixed broken import in AnalysisApp.jsx * feat(gwasV2Cleanup): Renamed all instances of GWASV2 to GWASApp * feat(gwasV2Cleanup): Ran ESLINT-new on changed files * feat(gwasV2Cleanup): Ran stylelint and formatted CSS * feat(gwasV2Cleanup): Deleted commented out CSS from GWASResults.css * feat(gwasV2Cleanup): changed class name from GWASApp-jobstats to GWASResults-jobStatus per PR comment * feat(gwasV2Cleanup): removed unneeded style declaration
pieterlukasse
approved these changes
Mar 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket:
VADC-414
VADC-290
VADC-287
VADC-456
VADC-431
VADC-437
New Features