VADC-446: Use a modified datetime of the themeoverrides.css to pull most recent version #1254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfshao
reviewed
Mar 22, 2023
* feat(resultAppSetupFE): setup home page * feat(resultsAppSetupFE): added useContext hook to maintain state * feat(resultsAppSetupFE): Setup Results and Execution data to display using useContext * feat(resultsAppSetupFE): simplified rand num code * feat(resultsAppSetupFE): fixed linter issues * feat(resultsAppSetupFE): fixed table layout issues * feat(resultsAppSetupFE): fixed style formatting * feat(resultsAppSetupFE): Created placeholder file for stoybook * feat(resultsAppSetupFE): Fixed broken storybook file * feat(resultsAppSetupFE): added multiple storybooks * feat(resultsAppSetupFE): added spinner and updated storybook * feat(resultsAppSetupFE): updated storybook to use null * feat(resultsAppSetupFE): cleaned up code * feat(resultsAppSetupFE): removed ref to deleted CSS file in ReturnHomeButton * feat(resultsAppSetupFE): added explanatory comment in GWASResultsContainer.jsx * feat(resultsAppSetupFE): made buttons more like design * feat(resultsAppSetupFE): reset poll timer to 5 seconds * feat(resultsAppSetupFE): ran eslint-new * feat(resultsAppSetupFE): addressed PR reviews comments, added ENUM for storing Views * feat(resultsAppSetupFE): fixed linting issues with proptypes * feat(resultsAppSetupFE): formatted code in HomeTable.jsx
* feat(resultsTableApiConnect): Added Pieter's code for GWASWorkflowList and got it to log data * feat(resultsTableApiConnect): Updated table component to print results * feat(resultsTableApiConnect): Fixed ESLINT-new issues * feat(resultsTableApiConnect): added results and execution data placeholders * feat(resultsTableApiConnect): Simplified app to use a single state to track selectedRowData * feat(resultsTableApiConnect): Ran ESLINT new and removed unneeded console statement * feat(resultsTableApiConnect): Removed comment in code * feat(resultsTableApiConnect): Removed unneeded directory and files * feat(resultsTableApiConnect): Wrote test for Home.jsx * feat(resultsTableApiConnect): Added tests * feat(resultsTableApiConnect): Fixed ESLINT issues * feat(resultsTableApiConnect): Created test data and fixed tests * feat(GwasAppSubmissionSpinner): Got storybook working for Home component * feat(resultsTableApiConnect): Added startedAt field to generated test data * feat(resultsTableApiConnect): rewrote Home.stories.jsx * feat(resultsTableApiConnect): cleaned up code in Home.stories.jsx * feat(resultsTableApiConnect): Formatted Home.stories.jsx * feat(resultsTableApiConnect): Simplified Home.stories.jsx via JS implicit return * feat(resultsTableApiConnect): Refactored Home.test.jsx to use shared test data * feat(resultsTableApiConnect): Ran eslint formatting * feat(resultsTableApiConnect): Formatted code for clarity * feat(resultsTableApiConnect): Edited comment for clarity
vzpgb
changed the title
pieterlukasse
approved these changes
Mar 23, 2023
There was a problem hiding this comment.
looks good to me 👍
I can also confirm I've seen it working when @vzpgb tested it on our QA server.
vzpgb
changed the title
jarvisraymond-uchicago
added a commit
that referenced
this pull request
Apr 3, 2023
…ost recent version (#1254) * Feat/results app setup fe (#1248) * feat(resultAppSetupFE): setup home page * feat(resultsAppSetupFE): added useContext hook to maintain state * feat(resultsAppSetupFE): Setup Results and Execution data to display using useContext * feat(resultsAppSetupFE): simplified rand num code * feat(resultsAppSetupFE): fixed linter issues * feat(resultsAppSetupFE): fixed table layout issues * feat(resultsAppSetupFE): fixed style formatting * feat(resultsAppSetupFE): Created placeholder file for stoybook * feat(resultsAppSetupFE): Fixed broken storybook file * feat(resultsAppSetupFE): added multiple storybooks * feat(resultsAppSetupFE): added spinner and updated storybook * feat(resultsAppSetupFE): updated storybook to use null * feat(resultsAppSetupFE): cleaned up code * feat(resultsAppSetupFE): removed ref to deleted CSS file in ReturnHomeButton * feat(resultsAppSetupFE): added explanatory comment in GWASResultsContainer.jsx * feat(resultsAppSetupFE): made buttons more like design * feat(resultsAppSetupFE): reset poll timer to 5 seconds * feat(resultsAppSetupFE): ran eslint-new * feat(resultsAppSetupFE): addressed PR reviews comments, added ENUM for storing Views * feat(resultsAppSetupFE): fixed linting issues with proptypes * feat(resultsAppSetupFE): formatted code in HomeTable.jsx * Feat/results table api connect (#1253) * feat(resultsTableApiConnect): Added Pieter's code for GWASWorkflowList and got it to log data * feat(resultsTableApiConnect): Updated table component to print results * feat(resultsTableApiConnect): Fixed ESLINT-new issues * feat(resultsTableApiConnect): added results and execution data placeholders * feat(resultsTableApiConnect): Simplified app to use a single state to track selectedRowData * feat(resultsTableApiConnect): Ran ESLINT new and removed unneeded console statement * feat(resultsTableApiConnect): Removed comment in code * feat(resultsTableApiConnect): Removed unneeded directory and files * feat(resultsTableApiConnect): Wrote test for Home.jsx * feat(resultsTableApiConnect): Added tests * feat(resultsTableApiConnect): Fixed ESLINT issues * feat(resultsTableApiConnect): Created test data and fixed tests * feat(GwasAppSubmissionSpinner): Got storybook working for Home component * feat(resultsTableApiConnect): Added startedAt field to generated test data * feat(resultsTableApiConnect): rewrote Home.stories.jsx * feat(resultsTableApiConnect): cleaned up code in Home.stories.jsx * feat(resultsTableApiConnect): Formatted Home.stories.jsx * feat(resultsTableApiConnect): Simplified Home.stories.jsx via JS implicit return * feat(resultsTableApiConnect): Refactored Home.test.jsx to use shared test data * feat(resultsTableApiConnect): Ran eslint formatting * feat(resultsTableApiConnect): Formatted code for clarity * feat(resultsTableApiConnect): Edited comment for clarity * feat(css): Add CSS version as datetime * feat(css): Move getCSSVerstion function * feat(css): Use relative path to themeoverrides.css * feat(css): Reorder * feat(css): Add condition to check if CSS file exists * feat(css): Removed unused code * feat(css): Removed redundant else statement --------- Co-authored-by: Jarvis <113449836+jarvisraymond-uchicago@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket: VADC-446
This PR uses the last modified date of the themeoverrides.css file at build time to set the version. This change allows performing automatic CSS pull after the gitops.css update.
Improvements