Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore/submit feedback #176

Merged
merged 2 commits into from
Oct 27, 2017
Merged

Chore/submit feedback #176

merged 2 commits into from
Oct 27, 2017

Conversation

frickjack
Copy link
Contributor

resolve #163
introduce SubmissionResult component to present submission summary:

  • 200 success - list number of entities submitted by type
  • 4XX error - list entities with errors
  • 504 timeout - explain timeout, suggest smaller submission

@frickjack
chore(Submission): enhance submission feedback
7547f6e 
* break down submission counts by type on success
* extract errors on failure
* show note on timeout
@frickjack
fix(SubmitTSV.test): sync tests with code changes
2d5b666 
Introduction of SubmissionResult component required
tweak of SubmitTSV.test due to DOM changes
@frickjack
Copy link
Contributor Author

Those 4 new Codacy issues result from the new code added, but do not actually reflect a decrease in code quality:

  • import 'brace' is needed by AceEditor to work properly for some reason - even though we don't use it directly
  • propTyps.object is not allowed is problematic, because the submission result data has a different shape depending on success or failure - this is not a regression
  • indentation 8 spaces is an eslint bug - if you indent 8, then it complains about that too
  • updating 'db' is idiomatic for the .reduce() function

thanh-nguyen-dang
thanh-nguyen-dang approved these changes Oct 27, 2017
View reviewed changes
Copy link
Contributor

@thanh-nguyen-dang thanh-nguyen-dang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@frickjack frickjack merged commit 9f92e39 into master Oct 27, 2017
@frickjack frickjack deleted the chore/submit-feedback branch October 27, 2017 19:12
This was referenced Nov 4, 2022
Open
Open
This was referenced Dec 25, 2022
Closed
Closed
This was referenced Dec 25, 2022
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thanh-nguyen-dang thanh-nguyen-dang thanh-nguyen-dang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add summary by type to submission page
2 participants
@frickjack @thanh-nguyen-dang