PXD-1214 fix(css): import ui-component and change all refer to base.less #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abgeorge7
reviewed
Jul 31, 2018
src/components/cards/CountBox.less
Outdated
| @@ -1,4 +1,4 @@ | |||
| @import '../../css/base.less'; | |||
| @import '../../../node_modules/@gen3/ui-component/dist/css/base.less'; | |||
There was a problem hiding this comment.
I don't think we want to import directly from node_modules, can it just be @import '@gen3/ui-component/...' ?
|
The text we fixed from black to white is black again on this branch also just fyi |
qingyashu
force-pushed
the
fix/css-refactor
branch
from
c5110b3 to
df39f85
Compare
|
Rebased. Check again~ |
abgeorge7
reviewed
Aug 1, 2018
|
Just some less-loader import rules: https://www.npmjs.com/package/less-loader#webpack-resolver |
abgeorge7
approved these changes
Aug 2, 2018
This was referenced Dec 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move base.less to @gen3/ui-component and now importing this module.