PXD-1491 Link to new Explorer page in dev #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not all of the apps have "buttons" in their config, but they all have "navigation." I also set the feature flag to be false for the explorer page so I think that the page will remain hidden. Want to double check with @thanh-nguyen-dang though |
This was referenced Dec 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "Exploration" button will go to the new data explorer when in the default/Generic Data Commons app. Also fixed a quick bug I noticed with outlines in the nav bar.
@thanh-nguyen-dang just wanted to make sure that only we use the default/Generic Data Commons config in parameters.js right? This won't be used by anyone external?