Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore/update terra template #663

Merged
merged 2 commits into from
Mar 26, 2020
Merged

Chore/update terra template #663

merged 2 commits into from
Mar 26, 2020

Conversation

ZakirG
Copy link
Contributor

@ZakirG ZakirG commented Mar 25, 2020 •
edited
Loading

Fulfills https://ctds-planx.atlassian.net/browse/PXP-5688

Deployed in https://qa-dcp.planx-pla.net/
Tested locally using gen3.biodatacatalyst.nhlbi.nih.gov/dev.html/explorer

Improvements

  • Add support for multiple Terra template values to be added as query parameters during the Export to Terra flow.

Deployment changes

  • The Terra template attribute in gitops.json now expects a list of strings, not just a single string.

themarcelor
themarcelor approved these changes Mar 25, 2020
View reviewed changes
Copy link
Contributor

@themarcelor themarcelor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@frickjack frickjack merged commit 4849d55 into master Mar 26, 2020
@frickjack frickjack deleted the chore/update-terra-template branch March 26, 2020 19:33
This was referenced May 13, 2020
Closed
Closed
Closed
Merged
Closed
Closed
Closed
Closed
Merged
This was referenced May 21, 2020
Merged
Merged
This was referenced Jun 3, 2020
Merged
Merged
Closed
@PlanXCyborg PlanXCyborg mentioned this pull request Jun 11, 2020
Merged
@PlanXCyborg PlanXCyborg mentioned this pull request Jul 6, 2020
Merged
@PlanXCyborg PlanXCyborg mentioned this pull request Jul 14, 2020
Merged
@PlanXCyborg PlanXCyborg mentioned this pull request Jan 25, 2021
Merged
@PlanXCyborg PlanXCyborg mentioned this pull request Dec 10, 2021
Closed
@PlanXCyborg PlanXCyborg mentioned this pull request Jan 11, 2022
Closed
@PlanXCyborg PlanXCyborg mentioned this pull request Feb 3, 2022
Closed
@PlanXCyborg PlanXCyborg mentioned this pull request Mar 2, 2022
Merged
This was referenced Apr 1, 2022
Closed
Closed
Closed
This was referenced Apr 1, 2022
Closed
Closed
Closed
@PlanXCyborg PlanXCyborg mentioned this pull request Oct 21, 2022
Closed
This was referenced Dec 19, 2023
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themarcelor themarcelor themarcelor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ZakirG @themarcelor @frickjack