Feat/peregrine request chunk #699
Conversation
…feat/peregrine-request-chunk
| .catch((err) => { | ||
| console.log(err); | ||
| }); | ||
| return; |
There was a problem hiding this comment.
also print something for other errors?
There was a problem hiding this comment.
Are you sure that's desirable? The original functionality did not print something for the other errors. If a query comes back with status code 500, I don't think a console print stating "The homepage chart node query came back with status code 500" would be desirable, or consistent with our usual error handling style in this repo.
There was a problem hiding this comment.
i don't have any strong feeling about it. but i think it would be more helpful to know what went wrong, plus we are already printing some error messages in other functions
Co-authored-by: Mingfei Shao <2475897+mfshao@users.noreply.github.com>
…cdis/data-portal into feat/peregrine-request-chunk
| .catch((err) => { | ||
| console.log(err); | ||
| }); | ||
| return; |
There was a problem hiding this comment.
i don't have any strong feeling about it. but i think it would be more helpful to know what went wrong, plus we are already printing some error messages in other functions
This PR splits the query for homepage chart nodes into multiple queries when more than 15 nodes are requested. The chunked query results are combined and rendered. You can run my unit tests with
npm test src/Index/utils.test.jsDeployed in https://zakir.planx-pla.net/
Fulfills https://ctds-planx.atlassian.net/browse/PXP-6235
Improvements
Deployment Changes