Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check all WTS OIDCs are signed in before download/export to WS #921

Merged
merged 5 commits into from
Sep 20, 2021
Merged

Check all WTS OIDCs are signed in before download/export to WS #921

merged 5 commits into from
Sep 20, 2021

Conversation

mcannalte
Copy link
Contributor

@mcannalte mcannalte commented Sep 10, 2021 •
edited
Loading

Jira Ticket: https://ctds-planx.atlassian.net/browse/HP-522

New Features

  • If configured, check that all external OIDCs in WTS are signed in before export to WS, direct download

Deployment changes

  • To enable this check, set features.exportToWorkspace.verifyExternalLogins flag to true in gitops

@mcannalte mcannalte force-pushed the feat/check_wts_auth branch 2 times, most recently from 3d7b358 to 28ae017 Compare September 13, 2021 20:24
@mcannalte mcannalte marked this pull request as ready for review September 13, 2021 20:28
@mcannalte mcannalte changed the title feat(check_wts_auth): check all WTS OIDCs are signed in before downlo… Check all WTS OIDCs are signed in before download/export to WS Sep 13, 2021
mfshao
mfshao reviewed Sep 16, 2021
View reviewed changes
Copy link
Collaborator

@mfshao mfshao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this deployed somewhere?

And please update /docs/portal_config.md

src/Discovery/DiscoveryActionBar.tsx Outdated Show resolved Hide resolved
src/Discovery/DiscoveryActionBar.tsx Show resolved Hide resolved
src/Discovery/DiscoveryActionBar.tsx Outdated Show resolved Hide resolved
mcannalte and others added 3 commits September 16, 2021 14:52
@mcannalte @mfshao
Update src/Discovery/DiscoveryActionBar.tsx
9134a0c 
Co-authored-by: Mingfei Shao <2475897+mfshao@users.noreply.github.com>
@mcannalte
feat(check_wts_auth):
978d7f5
@mcannalte
Merge branch 'feat/check_wts_auth' of github.com:uc-cdis/data-portal …
6969a9e 
…into feat/check_wts_auth
mfshao
mfshao approved these changes Sep 17, 2021
View reviewed changes
Copy link
Collaborator

@mfshao mfshao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested localy and it seems to be working fine 👍

@mcannalte mcannalte merged commit d3a40b2 into master Sep 20, 2021
@mcannalte mcannalte deleted the feat/check_wts_auth branch September 20, 2021 14:24
This was referenced Sep 21, 2021
Merged
Merged
@PlanXCyborg PlanXCyborg mentioned this pull request Sep 28, 2021
Open
This was referenced Oct 6, 2021
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Closed
This was referenced Oct 19, 2021
Merged
Merged
This was referenced Jan 26, 2022
Closed
Merged
This was referenced Feb 3, 2022
Closed
Merged
@PlanXCyborg PlanXCyborg mentioned this pull request Mar 2, 2022
Merged
This was referenced Mar 21, 2022
Merged
Merged
Merged
Merged
This was referenced Mar 29, 2022
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Apr 30, 2022
Closed
Closed
This was referenced Jun 23, 2022
Closed
Closed
@PlanXCyborg PlanXCyborg mentioned this pull request Jul 21, 2022
Open
@PlanXCyborg PlanXCyborg mentioned this pull request Sep 14, 2022
Merged
@PlanXCyborg PlanXCyborg mentioned this pull request Oct 21, 2022
Closed
This was referenced Dec 19, 2023
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfshao mfshao mfshao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcannalte @mfshao