Feat/numeric array filter sliders #114
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…added to storybook mock
…o get layout to match design
…and updated styles to better match design
…show total layout and a default layout
…ed excessive line breaks
…ed unneeded line of JSX from index.jsx
ocshawn
requested changes
May 19, 2023
| @@ -15,19 +15,23 @@ | |||
| flex-wrap: wrap; | |||
| justify-content: space-between; | |||
| margin: 14px 0; | |||
| color: var(--g3-color__base-blue); | |||
There was a problem hiding this comment.
does not meet accessibility guidelines for contrast, need a darker color
|
|
||
| .g3-range-filter__total { | ||
| background: var(--g3-color__silver); | ||
| color: var(--g3-color__base-blue); |
There was a problem hiding this comment.
does not meet accessibility guidelines for contrast
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket: MIDRC-5
New Features
This implements the front end design change for the range slider.
Breaking Changes
This is a redesign of the component and would impact anywhere the component is currently used
BEFORE
Design
https://xd.adobe.com/view/5ae05be7-d368-453f-8221-744abe876dfc-0fb3/screen/41843760-83e5-4bc9-a5c2-e16a7c9f3f36/
AFTER