Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update doc build action #208

Merged
merged 18 commits into from
Feb 7, 2024
Merged

update doc build action #208

merged 18 commits into from
Feb 7, 2024

Conversation

mfshao
Copy link
Contributor

@mfshao mfshao commented Feb 5, 2024

Improvements

  • Update docs build action so the commit it pushes can trigger other GH actions

Copy link

github-actions bot commented Feb 5, 2024

The style in this PR agrees with black. ✔️

This formatting comment was generated automatically by a script in uc-cdis/wool.

@mfshao mfshao marked this pull request as ready for review February 5, 2024 22:01
branches-ignore:
- 'master'
paths-ignore:
- 'docs/**'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit that is pushed by this docs build workflow won't trigger another doc build job. This behavior is expected

MaribelleHGomez
MaribelleHGomez previously approved these changes Feb 7, 2024
Copy link
Contributor

@MaribelleHGomez MaribelleHGomez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :)

@@ -14,6 +20,8 @@ jobs:
with:
ref: ${{github.event.pull_request.head.ref}}
repository: ${{github.event.pull_request.head.repo.full_name}}
# Passing a PAT from the PlanXCybrog bot account here, since otherwise commit pushed by this actions won't bale able to trigger other actions, see https://github.com/stefanzweifel/git-auto-commit-action?tab=readme-ov-file#commits-made-by-this-action-do-not-trigger-new-workflow-runs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small typo? "actions won't be able to trigger"

@MaribelleHGomez MaribelleHGomez self-requested a review February 7, 2024 20:01
@mfshao mfshao merged commit d966a10 into master Feb 7, 2024
12 checks passed
@mfshao mfshao deleted the fix/build-docs-action branch February 7, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants